[HGCAL trigger] Change exception to warning in cluster seeding

[jbsauvan]

PR following #49795 (comment) and #50043 (comment)
The goal is to be able to run on Spring24 Phase 2 MC samples without an exception being thrown due to HGCAL trigger cell positions out of the range expected by the HGCAL TPG seeding.

The exception is replaced by a warning message and the trigger cell positions are constrained within the seeding histogram range when filling the histogram, to avoid loosing them.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50062/47927

[cmsbuild]

A new Pull Request was created by @jbsauvan for master.

It involves the following packages:

• L1Trigger/L1THGCal (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray, @missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[kpedro88]

please test workflows 34551.85,34634.114,34634.21,34634.703,34634.99,34634.9921,34634.999

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-686898/51162/summary.html
COMMIT: 41378e8
CMSSW: CMSSW_16_1_X_2026-02-06-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50062/51162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
34634.114 step 2
34634.21 step 2
34634.703 step 2
34634.9921 step 3
34634.999 step 3
34634.99 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 189 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4173926
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4173891
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 242 log files, 212 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[mmusich]

enable gpu

[mmusich]

@cmsbuild, please test

• to see if this fixes also the broken GPU matrix

[BenjaminRS]

Thank you for this PR. I have tested running in 16_1_0_pre1 + this PR over Spring24 MC and could run without then getting the exceptions from before. There are a number of warning messages now; so it would be nice if the underlying problem is resolved in the future but I am happy to sign off on this once the tests complete.

[kpedro88]

@BenjaminRS are the warning messages just the ones from this PR, or are there others, too?

[BenjaminRS]

Hi @kpedro88 - the HGCAL warning messages are the ones from this PR.

[BenjaminRS]

+l1
This is fine from the L1 point of view.
Looks like there are issues with the GPU test mechanism.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

merge
tests seem stuck