Skip to content

Add various missing dictionaries#50065

Merged
cmsbuild merged 7 commits intocms-sw:masterfrom
makortel:aodDictionaries
Feb 8, 2026
Merged

Add various missing dictionaries#50065
cmsbuild merged 7 commits intocms-sw:masterfrom
makortel:aodDictionaries

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Feb 6, 2026

PR description:

This PR adds dictionaries for types that I saw ROOT triggering header parsing for in #49966

Resolves #49966
Resolves cms-sw/framework-team#1852

PR validation:

Running an AODSIM copy job through cmsTraceFunction ExecAutoParse no longer reports auto-parsing for these types.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 6, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 6, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50065/47929

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 6, 2026

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/MuonReco (reconstruction)
  • DataFormats/ParticleFlowCandidate (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/TauReco (reconstruction)
  • DataFormats/TrackReco (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @HuguesBrun, @Prasant1993, @Sam-Harper, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @amagitte, @azotz, @battibass, @cericeci, @elusian, @fsimone91, @gpetruc, @hatakeyamak, @jainshilpi, @jhgoh, @lgray, @llunerti, @mbluj, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @sameasy, @sobhatta, @trocino, @varuns23 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented Feb 6, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 6, 2026

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d501f0/51164/summary.html
COMMIT: 213b324
CMSSW: CMSSW_16_1_X_2026-02-06-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50065/51164/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4264973
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4264911
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 230 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Feb 8, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 8, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 9f05530 into cms-sw:master Feb 8, 2026
10 checks passed
@makortel makortel deleted the aodDictionaries branch February 9, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dictionaries that are missing in processing AOD Missing ROOT dictionaries when reading AODSIM

4 participants