Update HLTPixelThrustFilter to consider saturated pixels by stahlleiton · Pull Request #50167 · cms-sw/cmssw

stahlleiton · 2026-02-17T20:03:59Z

PR description:

This PR updates the HLTPixelThrustFilter module, which filters on the transverse thrust value of pixel clusters, to allow the option to also compute the transverse thrust considering only saturated pixel clusters or to cut on the number of pixel clusters.

This HLT filter is only used so far in the HIon menu to search for low-mass magnetic monopoles in ultra-peripheral PbPb collisions, which apart from leading to large values of transverse thrust are also expected to be highly ionizing and tend to saturate the pixel clusters. As such, adding the option to select on saturated clusters can help to further reduce the contributions from beam background, which in 2025 PbPb data taking ended up been much larger than in previous years.

PR validation:

Tested with relvals 141.201,141.202,142.201,142.202,143.201,143.202,144.201,144.202,180.0.180.1,181.0,181.1,182.0,182.1,183.0,183.1

@mandrenguyen @flodamas @vince502

cmsbuild · 2026-02-17T20:04:30Z

cms-bot internal usage

cmsbuild · 2026-02-17T20:06:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50167/48115

cmsbuild · 2026-02-17T20:06:58Z

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

HLTrigger/special (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2026-02-18T05:08:52Z

please test

cmsbuild · 2026-02-18T07:09:38Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831e06/51388/summary.html
COMMIT: 964ef94
CMSSW: CMSSW_16_1_X_2026-02-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50167/51388/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4167466
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4167443
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-02-18T14:52:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50167/48124

cmsbuild · 2026-02-18T14:52:44Z

Pull request #50167 was updated. @Martin-Grunewald, @cmsbuild, @mmusich, @tvami can you please check and sign again.

mmusich · 2026-02-18T15:18:28Z

test parameters:

workflows = 141.201, 141.202, 142.201, 142.202, 143.201, 143.202, 144.201, 144.202, 180.0, 180.1, 181.0, 181.1, 182.0, 182.1, 183.0, 183.1

mmusich · 2026-02-18T15:18:34Z

@cmsbuild, please test

cmsbuild · 2026-03-04T12:06:54Z

Pull request #50167 was updated. @Martin-Grunewald, @cmsbuild, @mmusich, @tvami can you please check and sign again.

mmusich · 2026-03-04T12:56:01Z

please test

cmsbuild · 2026-03-04T15:03:19Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831e06/51746/summary.html
COMMIT: bf1d445
CMSSW: CMSSW_16_1_X_2026-03-04-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50167/51746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 6414064
DQMHistoTests: Total failures: 64
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 6413980
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 303 log files, 266 edm output root files, 69 DQM output files
TriggerResults: no differences found

mmusich · 2026-03-05T16:49:13Z


+  size_t nSatPixels(0);
  std::vector<reco::LeafCandidate> vec;
+  vec.reserve(clusters.size() * 1000);


where's the 1000 coming from?

I checked locally with HIForward data and UPC MC, and saw that there were up to around 250 clusters in a detset, so to be conservative I multiplied the number of detsets by 1000 to reserve the vector. If prefered, I could either remove the reserve or count the total number clusters before reserving.

I am not sure how stable that number is going to be at the very end of the lifetime of the detector.

ok, in 915148b now it counts the total before reserving

cmsbuild · 2026-03-05T18:50:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50167/48401

cmsbuild · 2026-03-05T18:50:31Z

Pull request #50167 was updated. @Martin-Grunewald, @cmsbuild, @mmusich, @tvami can you please check and sign again.

mmusich · 2026-03-05T18:51:02Z

@cmsbuild, please test

cmsbuild · 2026-03-05T20:59:42Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831e06/51788/summary.html
COMMIT: 915148b
CMSSW: CMSSW_16_1_X_2026-03-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50167/51788/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 6414064
DQMHistoTests: Total failures: 70
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 6413974
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 303 log files, 266 edm output root files, 69 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-03-06T02:48:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50167/48406

cmsbuild · 2026-03-06T02:49:01Z

Pull request #50167 was updated. @Martin-Grunewald, @cmsbuild, @mmusich, @tvami can you please check and sign again.

mmusich · 2026-03-06T08:17:35Z

+hlt

for stahlleiton@56faab0
PR according to description and follow-up review
a speed-up of this filter was reported by the proponent at Update HLTPixelThrustFilter to consider saturated pixels #50167 (comment)

stahlleiton · 2026-03-06T09:25:04Z

@cms-sw/analysis-l2 : Please have a look and let me know if you have further comments or it is fine to sign, thanks.

mmusich · 2026-03-06T09:35:51Z

@cmsbuild, please test

cmsbuild · 2026-03-06T11:58:04Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831e06/51795/summary.html
COMMIT: 56faab0
CMSSW: CMSSW_16_1_X_2026-03-05-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50167/51795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 6414064
DQMHistoTests: Total failures: 114
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 6413930
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 303 log files, 266 edm output root files, 69 DQM output files
TriggerResults: no differences found

tvami · 2026-03-06T16:12:59Z

+1

looks good, thanks!

cmsbuild · 2026-03-06T16:13:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-03-07T09:49:35Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Feb 17, 2026

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 17, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 17, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 18, 2026

mmusich reviewed Feb 18, 2026

View reviewed changes

Comment thread HLTrigger/special/plugins/HLTPixelThrustFilter.cc Outdated

Comment thread HLTrigger/special/plugins/HLTPixelThrustFilter.cc Outdated

cmsbuild added tests-approved analysis-pending tests-pending code-checks-pending and removed tests-started tests-approved code-checks-approved labels Feb 18, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 18, 2026

cmsbuild removed the tests-pending label Feb 18, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 4, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 4, 2026

cmsbuild added tests-approved and removed tests-started labels Mar 4, 2026

mmusich reviewed Mar 5, 2026

View reviewed changes

Count pixels before reserving

915148b

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 5, 2026

Add upper limit on number of pixels

56faab0

cmsbuild mentioned this pull request Mar 7, 2026

[Python] Set memory policy to "strict" cms-sw/root#230

Closed

Conversation

stahlleiton commented Feb 17, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 17, 2026

Uh oh!

cmsbuild commented Feb 17, 2026

Uh oh!

Martin-Grunewald commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Feb 18, 2026

Comparison Summary

Uh oh!

cmsbuild commented Feb 18, 2026

Uh oh!

cmsbuild commented Feb 18, 2026

Uh oh!

mmusich commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Feb 18, 2026

Uh oh!

cmsbuild commented Mar 4, 2026

Uh oh!

mmusich commented Mar 4, 2026

Uh oh!

cmsbuild commented Mar 4, 2026

Comparison Summary

Uh oh!

mmusich Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

stahlleiton Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

mmusich Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

stahlleiton Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Mar 5, 2026

Uh oh!

cmsbuild commented Mar 5, 2026

Uh oh!

mmusich commented Mar 5, 2026

Uh oh!

cmsbuild commented Mar 5, 2026

Comparison Summary

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

mmusich commented Mar 6, 2026

Uh oh!

stahlleiton commented Mar 6, 2026

Uh oh!

mmusich commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Comparison Summary

Uh oh!

tvami commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

mandrenguyen commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

cmsbuild commented Feb 17, 2026 •

edited

Loading

mmusich commented Feb 18, 2026 •

edited

Loading