[EVOLUTION_X] Fix destructor definition for RegionalMuonShower by makortel · Pull Request #50332 · cms-sw/cmssw

makortel · 2026-03-06T16:43:13Z

PR description:

Should fix static analyzer error

src/DataFormats/L1TMuon/src/RegionalMuonShower.cc:21:26: error: destructor cannot be declared using a type alias 'RegionalMuonShower' (aka 'l1t::io_v1::RegionalMuonShower') of the class name [-Wdtor-typedef]
   21 | l1t::RegionalMuonShower::~RegionalMuonShower() {}
      |                          ^
1 error generated.

that we have seen in many EVOLUTION_X PR tests.

Resolves cms-sw/framework-team#2003

PR validation:

None (I checked the pattern in Compiler explorer)

cmsbuild · 2026-03-06T16:43:37Z

cms-bot internal usage

cmsbuild · 2026-03-06T16:45:10Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50332/48422

ERROR: Build errors found during clang-tidy run.

src/DataFormats/L1TMuon/src/RegionalMuonShower.cc:21:1: error: no member named 'l1t' in namespace 'l1t::io_v1'; did you mean simply 'l1t'? [clang-diagnostic-error]
   21 | io_v1::l1t::RegionalMuonShower::~RegionalMuonShower() {}
      | ^~~~~~~~~~
      | l1t
--
src/DataFormats/L1TMuon/src/RegionalMuonShower.cc:21:1: error: use of undeclared identifier 'io_v1'; did you mean 'l1t::io_v1'? [clang-diagnostic-error]
   21 | io_v1::l1t::RegionalMuonShower::~RegionalMuonShower() {}
      | ^
src/DataFormats/L1TMuon/interface/RegionalMuonShower.h:11:13: note: 'l1t::io_v1' declared here
--
src/DataFormats/L1TMuon/src/RegionalMuonShower.cc:21:33: error: destructor cannot be declared using a type alias 'RegionalMuonShower' (aka 'l1t::io_v1::RegionalMuonShower') of the class name [clang-diagnostic-dtor-typedef]
   21 | io_v1::l1t::RegionalMuonShower::~RegionalMuonShower() {}
      |                                 ^
Suppressed 471 warnings (471 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

To conform clang's interpretation of C++ standard

cmsbuild · 2026-03-06T16:53:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50332/48423

cmsbuild · 2026-03-06T16:54:05Z

A new Pull Request was created by @makortel for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

DataFormats/L1TMuon (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@dinyar, @eyigitba, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2026-03-06T17:01:13Z

@cmsbuild, please test

makortel · 2026-03-06T17:01:20Z

assign core

makortel · 2026-03-06T17:01:25Z

type evolution

cmsbuild · 2026-03-06T17:01:37Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2026-03-06T18:25:13Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51816/summary.html
COMMIT: 34d6cfb
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50332/51816/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51816/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51816/git-merge-result

Failed Build

I found compilation error when building:

>> Checking EDM Class Transients in RecoTrackerTkSeedingLayers
@@@@ ----> OK EDM Class Version RecoTrackerTkTrackingRegions
>> Checking EDM Class Transients in RecoTrackerTkTrackingRegions
@@@@ ----> OK EDM Class Version SimDataFormatsCaloHit
>> Checking EDM Class Transients in SimDataFormatsCaloHit
error: class 'MtdCaloParticle' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 374264907
Suggestion: You can run 'scram build updateclassversion' to generate src/SimDataFormats/CaloAnalysis/src/classes_def.xml.generated with updated ClassVersion
@@@@ ----> OK EDM Class Version SimDataFormatsDigiSimLinks
>> Checking EDM Class Transients in SimDataFormatsDigiSimLinks
gmake: *** [tmp/el8_amd64_gcc13/edm_checks/libSimDataFormatsCaloAnalysis.so] Error 1
>> Checking EDM Class Version for src/Validation/RecoVertex/bin/classes_def.xml in ValidationRecoVertexMacros

cmsbuild · 2026-03-06T21:33:25Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51824/summary.html
COMMIT: b20c0cf
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50332/51824/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51824/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-748f7a/51824/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test SimG4CMSForwardTestDriver had ERRORS

Failed RelVals

25202.0

----- Begin Fatal Exception 06-Mar-2026 22:05:52 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

2500.3001

----- Begin Fatal Exception 06-Mar-2026 22:15:46 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'edm::RangeMap<CSCDetId,edm::OwnVector<CSCSegment,edm::ClonePolicy<CSCSegment> >,edm::ClonePolicy<CSCSegment> >'
----- End Fatal Exception -------------------------------------------------

14234.0

----- Begin Fatal Exception 06-Mar-2026 22:10:08 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::HepMCProduct
  edm::Wrapper<edm::HepMCProduct>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  edm::HepMCProduct (read from input)

Missing dictionaries are associated with these branch names:

  edmHepMCProduct_generatorSmeared__RECOBEFMIX.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed AddOn Tests

pat1

----- Begin Fatal Exception 06-Mar-2026 22:04:10 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213llrxrd-redir.in2p3.fr&xrdcl.requuid=416f4544-6547-445a-aaf2-9ea88d598eb2
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

makortel · 2026-03-09T16:24:15Z

ignore tests-rejected with manual-override

Test failures will be addressed later

makortel · 2026-03-09T16:24:20Z

+core

civanch · 2026-03-09T20:45:40Z

+1

quinnanm · 2026-03-10T01:20:10Z

+l1

cmsbuild · 2026-03-10T01:20:33Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_1_EVOLUTION_X IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-03-10T06:28:34Z

+1

makortel mentioned this pull request Mar 6, 2026

[EVO] Moved HcalDigi products to versioned namespace #50325

Merged

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 6, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 6, 2026

Fix destructor definition for RegionalMuonShower

34d6cfb

To conform clang's interpretation of C++ standard

makortel force-pushed the patch-9 branch from d59a1fb to 34d6cfb Compare March 6, 2026 16:51

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 6, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 6, 2026

cmsbuild added core-pending tests-started evolution and removed tests-pending labels Mar 6, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 6, 2026

Update MtdCaloParticle checksum

b20c0cf

cmsbuild added the tests-started label Mar 6, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 6, 2026

cmsbuild added core-approved tests-approved tests-manual-override and removed core-pending tests-rejected labels Mar 9, 2026

cmsbuild added simulation-approved and removed simulation-pending labels Mar 9, 2026

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Mar 10, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 10, 2026

cmsbuild merged commit a5419c3 into cms-sw:CMSSW_16_1_EVOLUTION_X Mar 10, 2026
6 of 9 checks passed

makortel deleted the patch-9 branch March 10, 2026 13:37

Conversation

makortel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

makortel commented Mar 6, 2026

Uh oh!

makortel commented Mar 6, 2026

Uh oh!

makortel commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Uh oh!

cmsbuild commented Mar 6, 2026

Failed Build

Uh oh!

cmsbuild commented Mar 6, 2026

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

makortel commented Mar 9, 2026

Uh oh!

makortel commented Mar 9, 2026

Uh oh!

civanch commented Mar 9, 2026

Uh oh!

quinnanm commented Mar 10, 2026

Uh oh!

cmsbuild commented Mar 10, 2026

Uh oh!

mandrenguyen commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

makortel commented Mar 6, 2026 •

edited

Loading

cmsbuild commented Mar 6, 2026 •

edited

Loading