Skip to content

update runHLTTiming script to be more modular#50398

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:runHLTTiming_improve
Mar 13, 2026
Merged

update runHLTTiming script to be more modular#50398
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:runHLTTiming_improve

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Mar 13, 2026

PR description:

This PR refactors the benchmarking script by introducing two helper functions, run_cmsdriver and run_benchmark, in order to reduce code duplication and improve maintainability.

The main changes are:

  • Extract the repeated cmsDriver.py invocation into a reusable function run_cmsdriver.
  • Extract the repeated patatrack-scripts/benchmark workflow into a reusable function run_benchmark.
  • Keep the overall script structure and execution flow unchanged to preserve the current behavior.

No changes are expected in the output of the script. The refactoring is purely structural and intended to make future modifications (e.g. adding new menus or benchmark configurations) easier and less error-prone.

No additional dependencies are introduced and this PR does not depend on other PRs.

PR validation:

Will rely on the testing from the bot.
Since this change only reorganizes existing code without altering the workflow logic, no additional unit tests or matrix workflows were required.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport.

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 13, 2026

test parameters:

  • enable = hlt_p2_timing

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 13, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50398/48499

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 13, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89467c/51941/summary.html
COMMIT: 44dd4a0
CMSSW: CMSSW_16_1_X_2026-03-12-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50398/51941/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185208
  • DQMHistoTests: Total failures: 90
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185098
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 13, 2026

Comparing the timing pies obtained with this PR:

Phase2 timing menu (on GPU)

CMSSW_16_1_X_2026-03-12-2300 CMSSW_16_1_X_2026-03-12-2300 + this PR
Release_timing PR_timingGPU

Phase2 timing menu (on CPU)

CMSSW_16_1_X_2026-03-12-2300 CMSSW_16_1_X_2026-03-12-2300 + this PR
Release_timing_CPU PR_timing_CPU

NGT menu (on GPU)

CMSSW_16_1_X_2026-03-12-2300 CMSSW_16_1_X_2026-03-12-2300 + this PR
NGT_Release NGT_PR

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 13, 2026

+hlt

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit b479d1f into cms-sw:master Mar 13, 2026
12 checks passed
@mmusich mmusich deleted the runHLTTiming_improve branch March 13, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants