Skip to content

[EVO] Moved track related hits to versioned namespace#50403

Merged
cmsbuild merged 2 commits intocms-sw:CMSSW_16_1_EVOLUTION_Xfrom
Dr15Jones:evo_TrackHits
Mar 23, 2026
Merged

[EVO] Moved track related hits to versioned namespace#50403
cmsbuild merged 2 commits intocms-sw:CMSSW_16_1_EVOLUTION_Xfrom
Dr15Jones:evo_TrackHits

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Mar 13, 2026

PR description:

PR validation:

Code compiles.

resolves cms-sw/framework-team#2034

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 13, 2026

cms-bot internal usage

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

hold

this will conflict with #50379 so let that one go in first

@cmsbuild cmsbuild added the hold label Mar 13, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50403/48509

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

  • AnalysisDataFormats/TrackInfo (analysis)
  • DataFormats/Alignment (alca)
  • DataFormats/CSCRecHit (reconstruction)
  • DataFormats/DTRecHit (reconstruction)
  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/FTLRecHit (reconstruction)
  • DataFormats/GEMRecHit (reconstruction)
  • DataFormats/MuonSeed (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/RPCRecHit (reconstruction)
  • DataFormats/TrackCandidate (reconstruction)
  • DataFormats/TrackerRecHit2D (reconstruction)
  • DataFormats/TrackingRecHit (reconstruction)
  • DataFormats/TrajectorySeed (reconstruction)

@Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @jfernan2, @mandrenguyen, @perrotta, @srimanob, @tvami can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @HuguesBrun, @Prasant1993, @Sam-Harper, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @battibass, @cericeci, @elusian, @fabiocos, @fsimone91, @gpetruc, @hatakeyamak, @jainshilpi, @jhgoh, @jshlee, @lgray, @llunerti, @martinamalberti, @missirol, @mmasciov, @mmusich, @mtosi, @ptcox, @rovere, @rsreds, @sameasy, @sobhatta, @tocheng, @trocino, @varuns23, @watson-ij, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor

assign core

@cmsbuild
Copy link
Copy Markdown
Contributor

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

unhold

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50403/48616

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50403 was updated. @Dr15Jones, @Moanwar, @jfernan2, @makortel, @mandrenguyen, @smuzaffar, @srimanob, @tvami can you please check and sign again.

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dde5/52100/summary.html
COMMIT: 1bf68f8
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50403/52100/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dde5/52100/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dde5/52100/git-merge-result

Failed Unit Tests

I found 58 errors in the following unit tests:

---> test testConvertToRaw had ERRORS
---> test test_SpecialFullOutput had ERRORS
---> test test_HIonFullOutput had ERRORS
and more ...

Failed RelVals

----- Begin Fatal Exception 19-Mar-2026 19:04:02 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Mar-2026 19:04:30 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Mar-2026 19:04:18 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

Failed AddOn Tests

----- Begin Fatal Exception 19-Mar-2026 19:04:34 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213llrxrd-redir.in2p3.fr&xrdcl.requuid=8b6b7fba-11c5-49de-9ee3-8141c906cfeb
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Mar-2026 19:03:20 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling OutputModuleCore::keepThisBranch, checking dictionaries for kept types
Exception Message:
No data dictionary found for the following classes:

  GlobalObjectMapRecord

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Mar-2026 19:03:25 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_Fake2_DATA.root'
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake2_DATA.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake2_DATA.root.
      [c] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@makortel
Copy link
Copy Markdown
Contributor

type evolution

@makortel
Copy link
Copy Markdown
Contributor

ignore tests-rejected with manual-override

Test failures will be addressed later

@makortel
Copy link
Copy Markdown
Contributor

+core

@tvami
Copy link
Copy Markdown
Contributor

tvami commented Mar 20, 2026

+1

@jfernan2
Copy link
Copy Markdown
Contributor

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_1_EVOLUTION_X IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants