[EVO] Moved Phase2TrackerCluster1D to versioned namespace by Dr15Jones · Pull Request #50458 · cms-sw/cmssw

Dr15Jones · 2026-03-17T20:42:55Z

PR description:

PR validation:

Code compiles.

resolves cms-sw/framework-team#2061

cmsbuild · 2026-03-17T20:43:21Z

cms-bot internal usage

Dr15Jones · 2026-03-17T20:44:11Z

type evo

Dr15Jones · 2026-03-17T20:44:15Z

assign core

cmsbuild · 2026-03-17T20:44:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50458/48584

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TrackerRecHit2D/src/classes_def.xml modified in PR(s): [EVO] Moved track related hits to versioned namespace #50403

cmsbuild · 2026-03-17T20:45:02Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2026-03-17T20:45:04Z

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

DataFormats/Phase2TrackerCluster (reconstruction)
DataFormats/TrackerRecHit2D (reconstruction)

@Dr15Jones, @Moanwar, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @smuzaffar, @srimanob can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @elusian, @gpetruc, @missirol, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2026-03-17T20:48:37Z

please test

cmsbuild · 2026-03-17T20:51:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50458/48585

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/TrackerRecHit2D/src/classes_def.xml modified in PR(s): [EVO] Moved track related hits to versioned namespace #50403

cmsbuild · 2026-03-17T20:51:39Z

Pull request #50458 was updated. @Dr15Jones, @Moanwar, @jfernan2, @makortel, @mandrenguyen, @smuzaffar, @srimanob can you please check and sign again.

cmsbuild · 2026-03-17T22:57:33Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77763/52054/summary.html
COMMIT: 6196acb
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50458/52054/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77763/52054/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77763/52054/git-merge-result

Failed Build

I found compilation error when building:

>> Checking EDM Class Transients in DataFormatsDTRecHit
@@@@ ----> OK EDM Class Version DataFormatsCaloTowers
@@@@ ----> OK EDM Class Version DataFormatsCaloRecHit
>> Checking EDM Class Transients in DataFormatsCaloTowers
>> Checking EDM Class Transients in DataFormatsCaloRecHit
error: class 'reco::ClusterRemovalInfo' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 2001758756
@@@@ ----> OK EDM Class Version DataFormatsCandidate
>> Checking EDM Class Transients in DataFormatsCandidate
@@@@ ----> OK EDM Class Version DataFormatsCTPPSReco
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/TrackerRecHit2D/src/classes_def.xml.generated with updated ClassVersion
>> Checking EDM Class Transients in DataFormatsCTPPSReco

Static analyzer reported errors, please check

Dr15Jones · 2026-03-24T13:14:05Z

unhold

Dr15Jones · 2026-03-24T13:14:11Z

please test

cmsbuild · 2026-03-24T13:15:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50458/48678

cmsbuild · 2026-03-24T13:15:44Z

Pull request #50458 was updated. @Dr15Jones, @Moanwar, @jfernan2, @makortel, @mandrenguyen, @smuzaffar, @srimanob can you please check and sign again.

cmsbuild · 2026-03-24T16:00:35Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77763/52184/summary.html
COMMIT: 216bbca
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-23-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50458/52184/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 61 errors in the following unit tests:

---> test testHptdcPcl had ERRORS
---> test testPromptCalibProdSiStripLA had ERRORS
---> test testSSTGainPCL_fromRECO had ERRORS
and more ...

Failed RelVals

2023.0020001

----- Begin Fatal Exception 24-Mar-2026 16:25:03 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------

2025.0000001

----- Begin Fatal Exception 24-Mar-2026 16:25:51 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------

2024.0070001

----- Begin Fatal Exception 24-Mar-2026 16:25:22 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'GlobalObjectMapRecord'
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed AddOn Tests

pat1

----- Begin Fatal Exception 24-Mar-2026 16:29:10 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-redic.pi.infn.it&xrdcl.requuid=a570e6b9-9035-45c0-b9c8-245e7724387c
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

hlt_data_Fake2

----- Begin Fatal Exception 24-Mar-2026 16:28:08 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling OutputModuleCore::keepThisBranch, checking dictionaries for kept types
Exception Message:
No data dictionary found for the following classes:

  GlobalObjectMapRecord

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h
----- End Fatal Exception -------------------------------------------------

hlt_data_Fake2

----- Begin Fatal Exception 24-Mar-2026 16:28:19 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_Fake2_DATA.root'
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake2_DATA.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake2_DATA.root.
      [c] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

makortel · 2026-03-24T22:23:18Z

ignore tests-rejected with manual-override

Test failures will be addressed later

makortel · 2026-03-24T22:23:32Z

+core

mandrenguyen · 2026-03-25T07:49:05Z

merge

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk changes-dataformats labels Mar 17, 2026

Dr15Jones changed the title ~~Moved Phase2TrackerCluster1D to versioned namespace~~ [EVO] Moved Phase2TrackerCluster1D to versioned namespace Mar 17, 2026

cmsbuild added core-pending evolution labels Mar 17, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2026

Dr15Jones force-pushed the evo_Phase2TrackerCluster1D branch from 13c24ad to 6196acb Compare March 17, 2026 20:48

cmsbuild added tests-started code-checks-pending and removed tests-pending code-checks-approved labels Mar 17, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 23, 2026

Moved Phase2TrackerCluster1D to versioned namespace

216bbca

Dr15Jones force-pushed the evo_Phase2TrackerCluster1D branch from 6196acb to 216bbca Compare March 24, 2026 13:13

cmsbuild added tests-started code-checks-pending and removed tests-rejected hold code-checks-approved labels Mar 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 24, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 24, 2026

cmsbuild added core-approved tests-approved tests-manual-override and removed core-pending tests-rejected labels Mar 24, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 25, 2026

cmsbuild merged commit e549dc3 into cms-sw:CMSSW_16_1_EVOLUTION_X Mar 25, 2026
7 of 10 checks passed

Dr15Jones deleted the evo_Phase2TrackerCluster1D branch April 7, 2026 13:27

Conversation

Dr15Jones commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Mar 17, 2026

Uh oh!

Dr15Jones commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Uh oh!

Dr15Jones commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Uh oh!

cmsbuild commented Mar 17, 2026

Failed Build

Uh oh!

Dr15Jones commented Mar 24, 2026

Uh oh!

Dr15Jones commented Mar 24, 2026

Uh oh!

cmsbuild commented Mar 24, 2026

Uh oh!

cmsbuild commented Mar 24, 2026

Uh oh!

cmsbuild commented Mar 24, 2026

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

makortel commented Mar 24, 2026

Uh oh!

makortel commented Mar 24, 2026

Uh oh!

mandrenguyen commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dr15Jones commented Mar 17, 2026 •

edited

Loading

cmsbuild commented Mar 17, 2026 •

edited

Loading