Skip to content

[Backport] JME Offline DQM: adding trigger efficiency for scouting jets#50527

Merged
cmsbuild merged 14 commits intocms-sw:CMSSW_16_0_Xfrom
etzovara:JetMETScoutDQM_160X_ScoutTriggEff_backport
Apr 1, 2026
Merged

[Backport] JME Offline DQM: adding trigger efficiency for scouting jets#50527
cmsbuild merged 14 commits intocms-sw:CMSSW_16_0_Xfrom
etzovara:JetMETScoutDQM_160X_ScoutTriggEff_backport

Conversation

@etzovara
Copy link
Copy Markdown
Contributor

@etzovara etzovara commented Mar 24, 2026

PR description:

This PR summarises changes in the cmssw/DQMOffline/Trigger/ framework in order to include trigger efficiency calculations for scouting jets for offline monitoring. The relevant modules run only with online and offline scouting DQM with scouting datasets, to avoid crash due to missing scouting objects (specifically rho) from other datasets. Also, modules w/o JECs have been created in order to avoid similar crash in RelVals. (Issues thoroughly described in #49377 and #49358).

Relevant reports about the development and validation of this work can be found in:

cc: @silviodonato @patinkaew

PR validation:

This PR has been prepared starting from:

cmsrel CMSSW_16_1_X_2026-02-15-2300
cd CMSSW_16_1_X_2026-02-15-2300/src
cmsenv
git cms-init
git cms-addpkg DQMOffline/HLTScouting DQMOffline/Trigger DQMOffline/Configuration DQMOffline/JetMET PhysicsTools/SelectorUtils DQM/HLTEvF
scram b
scram build code-checks
scram build code-format

[1]: input: ScoutingPFMonitor/AOD/PromptReco-v1/ dataset (specifically testing with files from era 2025G, run 398827)
[2]: cmsDriver.py step2 -s DQM:jetmetScoutingMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec (or cmsDriver.py step2 -s DQM:jetmetScoutingNoJECsMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec)
[3]: cmsRun DQM_cfg.py
[4]: cmsDriver.py step3 -s HARVESTING:hltOfflineDQMClient --harvesting AtRunEnd --filein file:stepDQM.root --python_filename harvesting_cfg.py --conditions 150X_dataRun3_Prompt_v1 --data --filetype DQM --scenario pp --era Run3 --geometry DB:Extended -n -1 --no_exec
[5]: cmsRun harvesting_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of the original #50188. The reason of the backport is that the updates are intended for monitoring of jme objects during 2026 data taking.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 24, 2026

A new Pull Request was created by @etzovara for CMSSW_16_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQMOffline/HLTScouting (dqm)
  • DQMOffline/Trigger (dqm)
  • PhysicsTools/SelectorUtils (reconstruction)

@Martin-Grunewald, @Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 24, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50527 was updated. @Martin-Grunewald, @Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again.

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 25, 2026

@etzovara can you please rebase to avoid the merge commit?

@etzovara
Copy link
Copy Markdown
Contributor Author

@etzovara can you please rebase to avoid the merge commit?

@mmusich which merge commit do you refer to?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

@etzovara 1bb7f73

@etzovara
Copy link
Copy Markdown
Contributor Author

@mmusich I'm not sure I get it...shouldn't a merging be done anyway? why this is "bad"? (I'm asking just for my understanding)

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

I'm not sure I get it...shouldn't a merging be done anyway? why this is "bad"? (I'm asking just for my understanding)

You just want the merge of your PR and not another merge commit from merging your branch in the trunk (which will ruin the commit history for everyone)

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

@etzovara in any case the procedure is straightforward, see https://cms-sw.github.io/tutorial-resolve-conflicts.html

@etzovara
Copy link
Copy Markdown
Contributor Author

ok I see. I thought it was not necessary if I was just pushing my specific commits. So in any case, when starting a PR one should first rebase?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

I thought it was not necessary if I was just pushing my specific commits.

Indeed it wouldn't, had you not also pushed a merge commit.

So in any case, when starting a PR one should first rebase?

The general rule of thumb is that the commits should merge cleanly, thus if a conflict exists a rebase is necessary.

@etzovara
Copy link
Copy Markdown
Contributor Author

etzovara commented Mar 26, 2026

Ah I see... this merge commit must have been created from a commit that appeared here after I had pushed the PR and I resolved it from here. Otherwise, I had just pushed only my commits. So at this point, that I have created the backport PR, shall I just type git cms-rebase-topic etzovara:JetMETScoutDQM_160X_ScoutTriggEff_backport? Or shall I create a new branch?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

Or shall I create a new branch?

You can force push on the same

@etzovara
Copy link
Copy Markdown
Contributor Author

etzovara commented Mar 26, 2026

sorry @mmusich I ran the following commands:
git cms-rebase-topic etzovara:JetMETScoutDQM_160X_ScoutTriggEff_backport
git push my-cmssw JetMETScoutDQM_160X_ScoutTriggEff_backport
and I just get Everything up-to-date, but I don't see here another commit...
Did I miss anything?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

@etzovara

Did I miss anything?

Try by:

  • start from the last 16_0_X IB
  • cherry-pick your commits
  • force push on this same branch

@etzovara
Copy link
Copy Markdown
Contributor Author

@etzovara

Did I miss anything?

Try by:

* start from the last 16_0_X IB

* cherry-pick your commits

* force push on this same branch

so you'r suggesting to do it again from scratch, right?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 26, 2026

so you'r suggesting to do it again from scratch, right?

there's no need of a different PR, nor of a new branch, just follow the instructions.

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a67c3b/52300/summary.html
COMMIT: c8ea2bd
CMSSW: CMSSW_16_0_X_2026-03-26-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50527/52300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4166625
  • DQMHistoTests: Total failures: 120
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4166485
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 27195.928 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 18434.0,... ): 6798.982 KiB HLT/JME
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 27, 2026

backport of #50188

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 27, 2026

test parameters:

  • addpkg = DQM/Integration
  • relval_opts = -w data_highstats --nEvents 100
  • workflow = 2025.016005

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 27, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a67c3b/52307/summary.html
COMMIT: c8ea2bd
CMSSW: CMSSW_16_0_X_2026-03-26-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50527/52307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4265104
  • DQMHistoTests: Total failures: 135
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4264949
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 33994.91 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 18434.0,... ): 6798.982 KiB HLT/JME
  • Checked 231 log files, 202 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 27, 2026

+hlt

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

  • Tests passed in the DQM P5 playback environment

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Mar 27, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit f76c69a into cms-sw:CMSSW_16_0_X Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants