[Backport] JME Offline DQM: adding trigger efficiency for scouting jets#50527
Conversation
|
A new Pull Request was created by @etzovara for CMSSW_16_0_X. It involves the following packages:
@Martin-Grunewald, @Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
Pull request #50527 was updated. @Martin-Grunewald, @Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
@etzovara can you please rebase to avoid the merge commit? |
|
@mmusich I'm not sure I get it...shouldn't a merging be done anyway? why this is "bad"? (I'm asking just for my understanding) |
You just want the merge of your PR and not another merge commit from merging your branch in the trunk (which will ruin the commit history for everyone) |
|
@etzovara in any case the procedure is straightforward, see https://cms-sw.github.io/tutorial-resolve-conflicts.html |
|
ok I see. I thought it was not necessary if I was just pushing my specific commits. So in any case, when starting a PR one should first rebase? |
Indeed it wouldn't, had you not also pushed a merge commit.
The general rule of thumb is that the commits should merge cleanly, thus if a conflict exists a rebase is necessary. |
|
Ah I see... this merge commit must have been created from a commit that appeared here after I had pushed the PR and I resolved it from here. Otherwise, I had just pushed only my commits. So at this point, that I have created the backport PR, shall I just type |
You can force push on the same |
|
sorry @mmusich I ran the following commands: |
Try by:
|
so you'r suggesting to do it again from scratch, right? |
there's no need of a different PR, nor of a new branch, just follow the instructions. |
…trigger efficiency
…xis for Scouting jets
…n (applying also JetID,JECs,MuonID muon isol)
…equence analogous to 'jetmetScoutingMonitorHLT' but w/o JECs
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
backport of #50188 |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
+hlt |
|
+dqm
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR summarises changes in the cmssw/DQMOffline/Trigger/ framework in order to include trigger efficiency calculations for scouting jets for offline monitoring. The relevant modules run only with online and offline scouting DQM with scouting datasets, to avoid crash due to missing scouting objects (specifically rho) from other datasets. Also, modules w/o JECs have been created in order to avoid similar crash in RelVals. (Issues thoroughly described in #49377 and #49358).
Relevant reports about the development and validation of this work can be found in:
cc: @silviodonato @patinkaew
PR validation:
This PR has been prepared starting from:
cmsrel CMSSW_16_1_X_2026-02-15-2300
cd CMSSW_16_1_X_2026-02-15-2300/src
cmsenv
git cms-init
git cms-addpkg DQMOffline/HLTScouting DQMOffline/Trigger DQMOffline/Configuration DQMOffline/JetMET PhysicsTools/SelectorUtils DQM/HLTEvF
scram b
scram build code-checks
scram build code-format
[1]: input: ScoutingPFMonitor/AOD/PromptReco-v1/ dataset (specifically testing with files from era 2025G, run 398827)
[2]: cmsDriver.py step2 -s DQM:jetmetScoutingMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec (or cmsDriver.py step2 -s DQM:jetmetScoutingNoJECsMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec)
[3]: cmsRun DQM_cfg.py
[4]: cmsDriver.py step3 -s HARVESTING:hltOfflineDQMClient --harvesting AtRunEnd --filein file:stepDQM.root --python_filename harvesting_cfg.py --conditions 150X_dataRun3_Prompt_v1 --data --filetype DQM --scenario pp --era Run3 --geometry DB:Extended -n -1 --no_exec
[5]: cmsRun harvesting_cfg.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport of the original #50188. The reason of the backport is that the updates are intended for monitoring of jme objects during 2026 data taking.