HD full module readout corrected by rchudasa · Pull Request #50644 · cms-sw/cmssw

rchudasa · 2026-04-02T18:43:06Z

PR description:

This PR updates the unpacking of HD full module ECON-D data by adding the offset of +/- 37 indices.
The following changes were made.

muxMode field is introduced inHGCalROCConfig in HGCalConfiguration.h
It was populated from the JSON MultiPlex configuration file in HGCalConfigurationESProducer
In HGCalUnpacker, the dense channel index is shifted by (muxMode - erxIdx) * 37, so channel data are unpacked into the correct routing position.

Link to the issue created on HGCAL-DPG
https://gitlab.cern.ch/hgcal-dpg/hgcal-comm/-/issues/84

PR validation:

Plot shows the run taken with fixed ADC for one of the high density module and appears reasonable.

assign hgcal-dpg

cmsbuild · 2026-04-02T18:43:34Z

cms-bot internal usage

cmsbuild · 2026-04-02T18:45:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50644/48844

cmsbuild · 2026-04-02T18:46:09Z

A new Pull Request was created by @rchudasa for master.

It involves the following packages:

CondFormats/HGCalObjects (alca, db)
EventFilter/HGCalRawToDigi (reconstruction)
RecoLocalCalo/HGCalRecAlgos (reconstruction)

@Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please review it and eventually sign? Thanks.
@IzaakWN, @JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @missirol, @mmusich, @pfs, @rchatter, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @thomreis, @tocheng, @vandreev11, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Moanwar · 2026-04-02T19:18:35Z

@cmsbuild please test

cmsbuild · 2026-04-02T21:14:49Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97565d/52445/summary.html
COMMIT: 91a8b28
CMSSW: CMSSW_16_1_X_2026-04-02-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50644/52445/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4180749
DQMHistoTests: Total failures: 46
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4180683
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

pfs · 2026-04-03T06:36:04Z

assign hgcal-dpg

cmsbuild · 2026-04-03T06:36:26Z

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

pfs · 2026-04-03T06:36:55Z

test parameters:

enable = gpu
workflow = 77.0
workflow_gpu = 77.0
workflow_options_gpu = -w standard,gpu

pfs · 2026-04-03T06:37:07Z

please test

pfs · 2026-04-03T06:39:20Z

@Moanwar I forgot to give a heads up - for the moment these changes that involve the unpacker and local reco need to be tested with wf 77

cmsbuild · 2026-04-03T11:11:07Z

-1

Failed Tests: RelVals RelVals-AMD_MI300X
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97565d/52454/summary.html
COMMIT: 91a8b28
CMSSW: CMSSW_16_1_X_2026-04-02-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50644/52454/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

77.0A fatal system signal has occurred: abort signal

Failed RelVals-AMD_MI300X

77.077.0_HGCal_TestBeam/step1_HGCal_TestBeam.log

pfs · 2026-04-14T20:09:22Z

@@ -396,15 +398,16 @@ uint16_t HGCalUnpacker::parseFEDData(unsigned fedId,
                                      << erxHeader << ", cmSum = " << std::dec << cmSum;
          iword += 2;

+          const auto mux = fedConfig.econds[globalECONDIdx].rocs[erxIdx].muxMode;


same comment as above, maybe use const int32_t directly?

updated it.

cmsbuild · 2026-04-14T20:41:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50644/49004

cmsbuild · 2026-04-14T20:42:06Z

Pull request #50644 was updated. @Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @cseez, @felicepantaleo, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @pfs, @rovere, @srimanob can you please check and sign again.

pfs · 2026-04-14T20:55:45Z

please test

cmsbuild · 2026-04-14T21:15:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50644/49006

cmsbuild · 2026-04-14T21:15:37Z

Pull request #50644 was updated. @Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @cseez, @felicepantaleo, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @pfs, @rovere, @srimanob can you please check and sign again.

Alejandro1400 · 2026-04-15T08:50:20Z

please test

pfs · 2026-04-30T08:52:48Z

please test

pfs · 2026-04-30T08:57:11Z

@Alejandro1400 I think you may need to resolve the comments if you are happy with the updates in the code. Ideally we would like to have this in for the next release so we can use it in the test beams of May and in the Cassette production

pfs · 2026-04-30T08:57:14Z

+1

smuzaffar · 2026-04-30T14:41:44Z

Is it normal that relval 77.0 on AMD GPU w7900 is running for over 5 hours for baseline ? Should I kill it and re-try the job on a different host?

[a] https://cmssdt.cern.ch/jenkins/job/ib-run-baseline/24571/console

10:59:32 Preparing to run 77.0 HGCal_TestBeam
10:59:32 
10:59:32 # in: /scratch/cmsbuild/jenkins/workspace/ib-run-baseline/matrix-results going to execute cd 77.0_HGCal_TestBeam
 CUDA_VISIBLE_DEVICES= HIP_VISIBLE_DEVICES=0 cmsDriver.py step1  --conditions auto:phase2_realistic_T35 --era Phase2C22I13M9 --customise RecoLocalCalo/Configuration/hgcalTestBeamLocalReco_cff.runRecoForSep2024TB -s NONE --datatier RECO --eventcontent FEVTDEBUG --data  --process RECO -n 10 --filein /store/group/dpg_hgcal/comm_hgcal/relval/RAW2DIGI.root  --customise Validation/Performance/TimeMemoryJobReport.customiseWithTimeMemoryJobReport  --fileout file:step1.root  --suffix "-j JobReport1.xml "  > step1_HGCal_TestBeam.log  2>&1

pfs · 2026-04-30T15:08:27Z

yes please, it doesn't seem normal to me

rchudasa added 2 commits March 27, 2026 23:53

routing of eRX for HD unpacker

9351489

delta calculated outside the channel ID loop

91a8b28

cmsbuild added this to the CMSSW_16_1_X milestone Apr 2, 2026

cmsbuild added reconstruction-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending labels Apr 2, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 2, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 2, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 2, 2026

cmsbuild added the hgcal-dpg-pending label Apr 3, 2026

cmsbuild added tests-started and removed tests-approved labels Apr 3, 2026

pfs reviewed Apr 14, 2026

View reviewed changes

mux changed to const int32_t directly

32a156e

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2026

type casting the erxIdx to int in delta calculation

bf65c8d

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Apr 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2026

cmsbuild added hgcal-dpg-approved and removed hgcal-dpg-pending labels Apr 30, 2026

Conversation

rchudasa commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 2, 2026

Uh oh!

cmsbuild commented Apr 2, 2026

Uh oh!

Moanwar commented Apr 2, 2026

Uh oh!

cmsbuild commented Apr 2, 2026

Comparison Summary

Uh oh!

pfs commented Apr 3, 2026

Uh oh!

cmsbuild commented Apr 3, 2026

Uh oh!

pfs commented Apr 3, 2026

Uh oh!

pfs commented Apr 3, 2026

Uh oh!

pfs commented Apr 3, 2026

Uh oh!

cmsbuild commented Apr 3, 2026

Failed RelVals

Failed RelVals-AMD_MI300X

Uh oh!

pfs Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

rchudasa Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Apr 14, 2026

Uh oh!

cmsbuild commented Apr 14, 2026

Uh oh!

pfs commented Apr 14, 2026

Uh oh!

cmsbuild commented Apr 14, 2026

Uh oh!

cmsbuild commented Apr 14, 2026

Uh oh!

Alejandro1400 commented Apr 15, 2026

Uh oh!

pfs commented Apr 30, 2026

Uh oh!

pfs commented Apr 30, 2026

Uh oh!

pfs commented Apr 30, 2026

Uh oh!

smuzaffar commented Apr 30, 2026

Uh oh!

pfs commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rchudasa commented Apr 2, 2026 •

edited

Loading

cmsbuild commented Apr 2, 2026 •

edited

Loading