[EVOLUTION_X] Disable runTheMatrix workflows reading input data#50649
[EVOLUTION_X] Disable runTheMatrix workflows reading input data#50649cmsbuild merged 1 commit intocms-sw:CMSSW_17_0_EVOLUTION_Xfrom
Conversation
|
assign core |
|
type evolution |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50649/48851 |
|
New categories assigned: core @Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
A new Pull Request was created by @makortel for CMSSW_16_1_EVOLUTION_X. It involves the following packages:
@AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @cmsbuild, @makortel, @miquork, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test I wouldn't be surprised of failures e.g. because bot asks for workflows that don't exist with this PR. |
|
-1 Failed Tests: UnitTests RelVals AddOn Failed Unit TestsI found 1 errors in the following unit tests: ---> test test-runTheMatrix-interactive had ERRORS Failed RelValsValueError: Undefined workflows: 2500.3001, 18634.0, 17034.0, 34634.999, 13034.0, 10224.0, 25202.0, 312.0, 250202.181 Failed AddOn Tests |
|
@smuzaffar I couldn't find where cms-bot would require e.g. workflow 2500.3001 to be run. I dug a bit into cms-bot scripts, and found some workflows defined there (in But do I guess correctly that the bot establishes the set of workflows to run by default based on the baseline? (that's the best I could come up with for e.g. 2500.3001). Is there a way around that for a PR that removes workflows that are run in the |
|
@cmsbuild, please test with cms-sw/cms-bot#2715 |
|
@cmsbuild, please abort |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50649/48948 |
|
Pull request #50649 was updated. @AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @cmsbuild, @makortel, @miquork, @smuzaffar can you please check and sign again. |
|
@cmsbuild, please test with cms-sw/cms-bot#2715 |
|
@makortel , JR comparison job generates too much log data like [a] can cause the 500GB disk to full [b] [a] [b] |
Oops, sorry about that. Yeah, that is not good. |
|
Is the JR comparisons comparing the files from this PR to the |
|
Thanks, that explains. The ROOT files are incompatible by construction and can not be opened by the same ROOT-using process. I think we should either use the |
|
-1 Failed Tests: AddOn Failed AddOn TestsComparison Summary |
|
cms-sw/cms-bot#2719 was merged, so I guess we could test again here |
|
@cmsbuild, please test with cms-sw/cms-bot#2715 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67d65/52634/summary.html Comparison Summary |
|
@smuzaffar Seems like the comparisons were run, but the summary of the comparison was omitted from the message #50649 (comment) . Is that expected from cms-sw/cms-bot#2719? |
|
+core I think this PR is anyway good to go to EVOLUTION_X. |
|
merge |
PR description:
This PR disables
runTheMatrix.pyworkflows that unconditionally read input data. For MC workflows whose GEN step can be run on the fly, the reading of the input data is disabled.All changes were noted with
COMMENT: reads old format filecomment that we have used also for disabled unit tests.It is possible that I didn't catch everything in this PR, but it is much easier to discover them from the IBs than running the full runTheMatrix myself.
I'd imagine eventually many of these workflows could be removed (in CMSSW_20 or beyond), but that is not my call (I'd be happy to remove workflows instead of commenting them out if that is wanted).
Resolves cms-sw/framework-team#2112
PR validation:
runTheMatrix.py -nsucceeds locally.