[EVO] PFCandidate no longer inherits from CompositeCandidate by Dr15Jones · Pull Request #50682 · cms-sw/cmssw

Dr15Jones · 2026-04-07T18:42:44Z

PR description:

This simplification is intended to make it easier for ROOT to store this class.

The original attempt in the main line was done here #38999.

PR validation:

Code compiles.

resolves cms-sw/framework-team#2142

This simplification is intended to make it easier for ROOT to store this class.

Dr15Jones · 2026-04-07T18:42:53Z

type evo

Dr15Jones · 2026-04-07T18:42:58Z

assign core

Dr15Jones · 2026-04-07T18:43:04Z

please test

cmsbuild · 2026-04-07T18:43:08Z

cms-bot internal usage

cmsbuild · 2026-04-07T18:44:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50682/48911

cmsbuild · 2026-04-07T18:44:49Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2026-04-07T18:44:51Z

A new Pull Request was created by @Dr15Jones for CMSSW_17_0_EVOLUTION_X.

It involves the following packages:

DataFormats/ParticleFlowCandidate (reconstruction)
DataFormats/PatCandidates (reconstruction, xpog)

@Dr15Jones, @Moanwar, @battibass, @ftorrresd, @jfernan2, @makortel, @mandrenguyen, @smuzaffar, @srimanob can you please review it and eventually sign? Thanks.
@gouskos, @gpetruc, @hatakeyamak, @lgray, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2026-04-07T18:57:24Z

Originally done in #38999

cmsbuild · 2026-04-07T20:04:01Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb0ec6/52520/summary.html
COMMIT: 01bb37e
CMSSW: CMSSW_17_0_EVOLUTION_X_2026-04-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50682/52520/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

25202.0

----- Begin Fatal Exception 07-Apr-2026 21:33:32 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  GenEventInfoProduct
  edm::Wrapper<GenEventInfoProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  GenEventInfoProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  GenEventInfoProduct_generator__SIM.
  PCaloHits_g4SimHits_CaloHitsTk_SIM.
  PCaloHits_g4SimHits_CastorBU_SIM.
  PCaloHits_g4SimHits_CastorFI_SIM.
  PCaloHits_g4SimHits_CastorPL_SIM.
  PCaloHits_g4SimHits_CastorTU_SIM.
  PCaloHits_g4SimHits_ChamberHits_SIM.
  PCaloHits_g4SimHits_EcalHitsEB_SIM.
  PCaloHits_g4SimHits_EcalHitsEE_SIM.
  PCaloHits_g4SimHits_EcalHitsES_SIM.
  PCaloHits_g4SimHits_EcalTBH4BeamHits_SIM.
  PCaloHits_g4SimHits_FibreHits_SIM.
  PCaloHits_g4SimHits_HFNoseHits_SIM.
  PCaloHits_g4SimHits_HGCHitsEE_SIM.
  PCaloHits_g4SimHits_HGCHitsHEback_SIM.
  PCaloHits_g4SimHits_HGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_HcalHits_SIM.
  PCaloHits_g4SimHits_HcalTB06BeamHits_SIM.
  PCaloHits_g4SimHits_WedgeHits_SIM.
  PCaloHits_g4SimHits_ZDCHITS_SIM.
  PSimHits_g4SimHits_BCM1FHits_SIM.
  PSimHits_g4SimHits_BHMHits_SIM.
  PSimHits_g4SimHits_BSCHits_SIM.
  PSimHits_g4SimHits_FP420SI_SIM.
  PSimHits_g4SimHits_FastTimerHitsBarrel_SIM.
  PSimHits_g4SimHits_FastTimerHitsEndcap_SIM.
  PSimHits_g4SimHits_MuonCSCHits_SIM.
  PSimHits_g4SimHits_MuonDTHits_SIM.
  PSimHits_g4SimHits_MuonGEMHits_SIM.
  PSimHits_g4SimHits_MuonME0Hits_SIM.
  PSimHits_g4SimHits_MuonRPCHits_SIM.
  PSimHits_g4SimHits_PLTHits_SIM.
  PSimHits_g4SimHits_TotemHitsRP_SIM.
  PSimHits_g4SimHits_TotemHitsT1_SIM.
  PSimHits_g4SimHits_TotemHitsT2Gem_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBLowTof_SIM.
  SimTracks_g4SimHits__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

2500.3001A fatal system signal has occurred: segmentation violation
14234.0

----- Begin Fatal Exception 07-Apr-2026 21:39:00 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::HepMCProduct
  edm::Wrapper<edm::HepMCProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  edm::HepMCProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)

Missing dictionaries are associated with these branch names:

  PCaloHits_fastSimProducer_EcalHitsEB_RECOBEFMIX.
  PCaloHits_fastSimProducer_EcalHitsEE_RECOBEFMIX.
  PCaloHits_fastSimProducer_EcalHitsES_RECOBEFMIX.
  PCaloHits_fastSimProducer_HcalHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonCSCHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonDTHits_RECOBEFMIX.
  PSimHits_MuonSimHits_MuonRPCHits_RECOBEFMIX.
  PSimHits_fastSimProducer_TrackerHits_RECOBEFMIX.
  SimTracks_fastSimProducer_MuonSimTracks_RECOBEFMIX.
  SimTracks_fastSimProducer__RECOBEFMIX.
  edmHepMCProduct_generatorSmeared__RECOBEFMIX.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed AddOn Tests

pat1

----- Begin Fatal Exception 07-Apr-2026 21:23:55 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-redic.pi.infn.it&xrdcl.requuid=884bf9f9-25e0-459a-9a82-c3d90c3158f5
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

makortel · 2026-04-14T13:51:38Z

@cmsbuild, please test with cms-sw/cms-bot#2715

PR test RelVals should now technically run.

cmsbuild · 2026-04-14T15:39:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb0ec6/52658/summary.html
COMMIT: 01bb37e
CMSSW: CMSSW_17_0_EVOLUTION_X_2026-04-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50682/52658/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

makortel · 2026-04-14T15:43:22Z

RelVals succeeded

43 42 41 37 17 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

(with comparisons still being missing)

makortel · 2026-04-14T15:43:42Z

+core

jfernan2 · 2026-04-14T15:44:08Z

+1

mandrenguyen · 2026-04-15T08:08:04Z

merge

PFCandidate no longer inherits from CompositeCandidate

01bb37e

This simplification is intended to make it easier for ROOT to store this class.

cmsbuild added reconstruction-pending core-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending changes-dataformats evolution labels Apr 7, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 7, 2026

makortel mentioned this pull request Apr 7, 2026

PFCandidate no longer inherits from CompositeCandidate #38999

Closed

cmsbuild added tests-rejected and removed tests-started labels Apr 7, 2026

cmsbuild added requires-external tests-started and removed tests-rejected labels Apr 14, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 14, 2026

cmsbuild added core-approved and removed core-pending labels Apr 14, 2026

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 14, 2026

cmsbuild added orp-approved and removed orp-pending labels Apr 15, 2026

cmsbuild merged commit cf7fd85 into cms-sw:CMSSW_17_0_EVOLUTION_X Apr 15, 2026
9 checks passed

cmsbuild mentioned this pull request Apr 17, 2026

[EVO] Fix merge conflict 2026/04/17 #50751

Merged

Conversation

Dr15Jones commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

Dr15Jones commented Apr 7, 2026

Uh oh!

Dr15Jones commented Apr 7, 2026

Uh oh!

Dr15Jones commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026

Uh oh!

makortel commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026

Failed RelVals

Failed AddOn Tests

Uh oh!

makortel commented Apr 14, 2026

Uh oh!

cmsbuild commented Apr 14, 2026

Comparison Summary

Uh oh!

makortel commented Apr 14, 2026

Uh oh!

makortel commented Apr 14, 2026

Uh oh!

jfernan2 commented Apr 14, 2026

Uh oh!

mandrenguyen commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dr15Jones commented Apr 7, 2026 •

edited

Loading

cmsbuild commented Apr 7, 2026 •

edited

Loading