Skip to content

Add missing dependence on ROOT to CondFormats/MLObjects#50692

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
makortel:patch-9
Apr 9, 2026
Merged

Add missing dependence on ROOT to CondFormats/MLObjects#50692
cmsbuild merged 1 commit intocms-sw:masterfrom
makortel:patch-9

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Apr 8, 2026

PR description:

The package CondFormats/MLObjects declares dictionaries and thus needs to depend on ROOT. Discovered in cms-sw/cmsdist#10475 (comment)

Resolves cms-sw/framework-team#2147

PR validation:

None

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • CondFormats/MLObjects (db, ml)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @hjkwon260, @perrotta, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @seemasharmafnal, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented Apr 8, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2f9cc/52552/summary.html
COMMIT: ca32ec1
CMSSW: CMSSW_17_0_X_2026-04-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50692/52552/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2f9cc/52552/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2f9cc/52552/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4181709
  • DQMHistoTests: Total failures: 47
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 4181624
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 23540.622999999992 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 478.125 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 10224.0,... ): 618.750 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 11634.0,... ): 632.812 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 2022.0010001,... ): 604.688 KiB Hcal/DigiTask
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Copy Markdown
Contributor

perrotta commented Apr 9, 2026

+db

@hjkwon260
Copy link
Copy Markdown
Contributor

+ml

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit aaff5e9 into cms-sw:master Apr 9, 2026
10 checks passed
@makortel makortel deleted the patch-9 branch April 9, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing dependence on ROOT to CondFormats/MLObjects

5 participants