Sync FASTPU_X changes in to main CMSSW by smuzaffar · Pull Request #50886 · cms-sw/cmssw

smuzaffar · 2026-05-05T17:45:02Z

As requested during the ORP meeting, this PR syncs back the changes from FASTPU_X branch in to main 17.0.X IBs

…ts through the MixingModule interface to be used during the Digitization step in different sub-systems

…ent of remaining couts

…k is set to True for FastPU with FastSimPU modifier in python/mix_probFunction_25ns_PoissonOOTPU_cfi.py

…l from FullSim and PU frm FastSim

…ags for Signal/PileUp SimHit collection

cmsbuild · 2026-05-05T17:45:34Z

cms-bot internal usage

cmsbuild · 2026-05-05T17:47:47Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50886/49239

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Rpc digi dev v9 #47447, update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File SimMuon/RPCDigitizer/python/muonRPCDigis_cfi.py modified in PR(s): Rpc digi dev v9 #47447
- File SimMuon/RPCDigitizer/src/RPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50886/49239/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50886/49239/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-05-05T18:06:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50886/49240

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Rpc digi dev v9 #47447, update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File SimMuon/RPCDigitizer/python/muonRPCDigis_cfi.py modified in PR(s): Rpc digi dev v9 #47447
- File SimMuon/RPCDigitizer/src/RPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447

cmsbuild · 2026-05-05T18:06:59Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
Configuration/PyReleaseValidation (pdmv)
SimCalorimetry/EcalSimProducers (simulation)
SimCalorimetry/HcalSimProducers (simulation)
SimGeneral/MixingModule (simulation)
SimGeneral/TrackingAnalysis (simulation)
SimMuon/CSCDigitizer (simulation)
SimMuon/DTDigitizer (simulation)
SimMuon/GEMDigitizer (simulation)
SimMuon/RPCDigitizer (simulation)
SimTracker/SiPixelDigitizer (simulation)
SimTracker/SiStripDigitizer (simulation)

@AdrianoDee, @DickyChant, @antoniovagnerini, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abbiendi, @abdoulline, @argiro, @bsunanda, @cericeci, @dgulhan, @dkotlins, @echabert, @elusian, @fabiocos, @ferencek, @fsimone91, @giovanni-mocellin, @jhgoh, @jshlee, @llunerti, @makortel, @mariadalfonso, @martinamalberti, @mmasciov, @mmusich, @mroguljic, @mtosi, @prolay, @ptcox, @rchatter, @robervalwalsh, @rovere, @sameasy, @slomeo, @thomreis, @threus, @trocino, @tsusa, @wang0jin, @watson-ij this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2026-05-05T18:12:47Z

please test

kpedro88 · 2026-05-05T18:17:43Z

FYI @subirsarkar @suchandradutta

cmsbuild · 2026-05-05T18:24:05Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 132KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53087/summary.html
COMMIT: 6653004
CMSSW: CMSSW_17_0_X_2026-05-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50886/53087/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@jprendi Add missing protection for beamspot vertex in Scouting Collection DQM #50871

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53087/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53087/git-merge-result

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

Static analyzer reported errors, please check

kpedro88 · 2026-05-05T18:32:42Z

SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc
src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc:302:9: warning: variable 'totalDigis' set but not used [-Wunused-but-set-variable]
SimTracker/SiStripDigitizer/plugins/SiStripDigitizer.cc
src/SimTracker/SiStripDigitizer/plugins/SiStripDigitizer.cc:292:7: warning: variable 'totalDigis' set but not used [-Wunused-but-set-variable]

It looks like totalDigis was added for debugging during development and could be removed. @smuzaffar do you want me to send a PR to your branch?

smuzaffar · 2026-05-05T20:57:32Z

please test

cmsbuild · 2026-05-05T20:59:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50886/49243

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Rpc digi dev v9 #47447, update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
- File SimMuon/RPCDigitizer/python/muonRPCDigis_cfi.py modified in PR(s): Rpc digi dev v9 #47447
- File SimMuon/RPCDigitizer/src/RPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447

cmsbuild · 2026-05-05T20:59:49Z

Pull request #50886 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @civanch, @davidlange6, @fabiocos, @ftenchini, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @sroychow can you please check and sign again.

cmsbuild · 2026-05-05T23:01:39Z

+1

Size: This PR adds an extra 144KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53093/summary.html
COMMIT: 7be8e1b
CMSSW: CMSSW_17_0_X_2026-05-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50886/53093/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@jprendi Add missing protection for beamspot vertex in Scouting Collection DQM #50871

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53093/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dea1d2/53093/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4420967
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4420941
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 235 log files, 207 edm output root files, 55 DQM output files
TriggerResults: found differences in 1 / 53 workflows

Suchandra and others added 14 commits May 5, 2026 19:35

Code updates to use FastSim events as PileUp with FullSim Signal even…

591812c

…ts through the MixingModule interface to be used during the Digitization step in different sub-systems

code related feedback from release managers implemented

9a0beda

reverting to std::set again in Muon/Calo Digitizers, removal/replacem…

37afc4c

…ent of remaining couts

Added new parameter skipProductCheck in MixingModule. skipProductChec…

3c093b3

…k is set to True for FastPU with FastSimPU modifier in python/mix_probFunction_25ns_PoissonOOTPU_cfi.py

add hybrid pileup workflows

0495b4c

include modifier in all subsequent steps

58d3d9b

Separate HcalTestNumbering flag for signal and PU which enables signa…

c06e81a

…l from FullSim and PU frm FastSim

Code checks

d459d6a

Change back testnumbering in AddCaloSamplesAnalyzer.py

32b38d2

handle multiple input tags in mixing for SimVertex and SimTrack

a36d037

dummy comment

49e53cb

code format change

db05dee

Bug fix in Ecal/Hcal digitizers; removed std::set which stored InputT…

c3eb443

…ags for Signal/PileUp SimHit collection

Sync changes from FASTPU_X branch

4843866

cmsbuild added this to the CMSSW_17_0_X milestone May 5, 2026

cmsbuild added simulation-pending operations-pending pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending tracking trk labels May 5, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 5, 2026

Apply code format changes

6653004

cmsbuild removed the code-checks-rejected label May 5, 2026

cmsbuild added the code-checks-pending label May 5, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2026

cmsbuild added tests-started and removed tests-pending labels May 5, 2026

cmsbuild added tests-rejected and removed tests-started labels May 5, 2026

fix compilation warning and debug build error

7be8e1b

cmsbuild added tests-started code-checks-pending and removed tests-rejected code-checks-approved labels May 5, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2026

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels May 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync FASTPU_X changes in to main CMSSW#50886

Sync FASTPU_X changes in to main CMSSW#50886
smuzaffar wants to merge 16 commits intocms-sw:masterfrom
smuzaffar:sync-fastpu-changes

smuzaffar commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026 •

edited

Loading

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

smuzaffar commented May 5, 2026

Uh oh!

kpedro88 commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

kpedro88 commented May 5, 2026

Uh oh!

smuzaffar commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

smuzaffar commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

smuzaffar commented May 5, 2026

Uh oh!

kpedro88 commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Failed Clang Build

Uh oh!

kpedro88 commented May 5, 2026

Uh oh!

smuzaffar commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Uh oh!

cmsbuild commented May 5, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented May 5, 2026 •

edited

Loading