Egg and Acid Trap corner triggers - #12725
Open
JackieEstegado wants to merge 6 commits into
Open
Conversation
cmss13-ci
Bot
added
Fix
Contributor
|
fascinating implementation |
cm13-github
added
the
Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #12477
Fixes bug with Eggs and Acid Traps where they would trigger through corners of walls.
I am using hearers() proc to achieve this, best I could find.
Explain why it's good for the game
Making marines cry bad.
Testing Photographs and Procedure
Testing
Place traps/eggs on the corners of one side.
Walk around with human on other side.
Zero triggers.
Walk on same side, triggered.
Dropped on top of the eggs/traps, triggered.
Changelog
🆑
fix: Eggs and acid traps no longer trigger through corners of walls.
/:cl: