[REFACTOR] Moves most of Dancer behavior code and vars to respective abilities. - #12734
Open
Venuska1117 wants to merge 1 commit into
Open
[REFACTOR] Moves most of Dancer behavior code and vars to respective abilities.#12734Venuska1117 wants to merge 1 commit into
Venuska1117 wants to merge 1 commit into
Conversation
cmss13-ci
Bot
added
Refactor
Venuska1117
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detached from: #12601
About the pull request
Moved vars from behavior to respective abilities, replaced some of TRUE/FALSE vars with traits for easier reference in different files or in future code.
Explain why it's good for the game
Cleaner code, easier to follow.
Testing Procedure
Made new code, run code, no errors.
spawn praetorian, strain to dancer, use abilities, abilities work fine.
Code works as intended.
Changelog
🆑 Venuska1117
refactor: Changed most of Dancer Praetorian ability vars to use traits, for easier reference in future, behaviour vars that are used by specific ability are moved to ability file.
/:cl: