Sharp Resharpening: Safety PR Split - #12748
Open
MPhonks wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This is a split of #11698 containing the safety-logic and QOL improvements to the P9 Sonic Harpoon Artillery Remote Projectile (SHARP) Rifle. It replaces the different firemode timers (2.5s, 5s, defaults to 2.5s) with a mine-safety toggle ("SAFE" mode). Apart from the change of incendiary mines to be strictly square, nothing balance-wise has been changed and is reserved for future PR(s).
Of the QOL changes are included:
Explain why it's good for the game
As it stands right now, the SHARP contains fundamental design flaws. SHARP has been stamped off as a "xenoagent" role in the game which does more harm to the marine force than good. This PR does not aim to handhold the kit into becoming "the new meta", but rather addresses scenarios where the usage of the SHARP would be more helpful to aliens than to the marine force.
With SAFE mode, placing mines directly where marines walk and push becomes a reliable tool of both securing the backline and ensuring that marines do not suffer fatalities to the mines when pushed back. The mines refuse to detonate when anyone with IFF can be hurt by them, at the cost of potentially fizzling out when hitting xenomorphs directly, or missing out on kills from the potentially obtained stun they cause.
Testing Photographs and Procedure
Screenshots & Videos
See #11698 .Changelog
🆑 MarpleJones
del: SHARP timer modes (5s, 2.5s) removed, default at 2.5s
add: adds SHARP safety mode, which has greater IFF logic and prevents the mine from detonating when near friendlies.
add: you can now rearm SHARP mines as the SHARP specialist with a security access tuner (multitool)
add: adds a security access tuner to the specialist kit
add: small xenomorph no longer trigger sharp mines
add: square fireshape
balance: incendiary mines are now strictly square
qol: firemodes as a specialist ability, extended description for mine timers and modes, magazine autoejection
/:cl: