cockpit-desktop: clarify error when cockpit-bridge is missing - #22803
Closed
aravindhaj17 wants to merge 1 commit into
Closed
cockpit-desktop: clarify error when cockpit-bridge is missing#22803aravindhaj17 wants to merge 1 commit into
aravindhaj17 wants to merge 1 commit into
Conversation
martinpitt
requested changes
Jan 26, 2026
martinpitt
left a comment
martinpitt
left a comment
Member
There was a problem hiding this comment.
Thanks! This needs to be refined a bit, but surely improves the error message.
| # start the bridge; this needs to run in the normal user session/namespace | ||
| echo "cockpit-desktop: attempting to start cockpit-bridge locally" | ||
|
|
||
| if ! command -v cockpit-bridge >/dev/null 2>&1; then |
Member
There was a problem hiding this comment.
This needs to be refined to take the optional second "ssh host" CLI argument into account. I.e. it does not make sense to check for cockpit-bridge locally if $2 contains a ssh host.
Member
|
Proposed an alternative approach here #23144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves the user-facing error message when cockpit-bridge is not found and adds a brief explanation before attempting to start it.
Why
Previously, the root cause was obscured by unrelated terminal output, which made the failure confusing for users.
Testing
Manually verified the messaging when cockpit-bridge is not installed.
Fixes #20766