Skip to content

backport some skips from main #23219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allisonkarlitskaya wants to merge 2 commits into
base: rhel-8
Choose a base branch
from
Open

backport some skips from main #23219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ffefc3
test: Skip tests which currently don't work on rhel-8-10/ws-container
martinpitt Oct 24, 2024
58a6737
test: Skip more LUKS tests on rhel-8-10
martinpitt Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/verify/check-metrics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def login(self):
self.login_and_go("/metrics")


@testlib.skipImage("FIXME: python3-pcp not currently on image", "rhel-8-10")

@martinpitt martinpitt May 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand these. The last rhel-8 landed PR #23138 was happy. Either we added python3-pcp to the rhel-8-10 image already, or something else is wrong and broke the rhel-8 branch on main?

@testlib.skipDistroPackage()
class TestHistoryMetrics(testlib.MachineCase):
def setUp(self):
Expand Down Expand Up @@ -1271,6 +1272,7 @@ BEGIN {{


@testlib.skipImage("TODO: Arch Linux packagekit support", "arch")
@testlib.skipImage("FIXME: python3-pcp not currently on image", "rhel-8-10")
@testlib.skipDistroPackage()
class TestMetricsPackages(packagelib.PackageCase):
# HACK: PF modal can have multiple id's in certain scenario's https://github.com/patternfly/patternfly-react/issues/9399
Expand Down Expand Up @@ -1386,6 +1388,7 @@ class TestMetricsPackages(packagelib.PackageCase):
self.assertIn("redis", m.execute("systemctl show -p Wants --value pmproxy").strip())


@testlib.skipImage("FIXME: python3-pcp not currently on image", "rhel-8-10")
@testlib.skipDistroPackage()
class TestMultiCPU(testlib.MachineCase):

Expand Down
1 change: 1 addition & 0 deletions test/verify/check-networkmanager-firewall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class TestFirewall(netlib.NetworkCase):
if m.image == "arch":
m.execute("firewall-cmd --zone 'public' --change-interface='eth0'; firewall-cmd --runtime-to-permanent")

@testlib.skipImage("FIXME: get_num_zones() race condition, moves from 1 to 2", "rhel-8-10")
def testNetworkingPage(self):
b = self.browser
m = self.machine
Expand Down
2 changes: 2 additions & 0 deletions test/verify/check-packagekit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ ExecStart=/usr/local/bin/{packageName}
b.wait_visible("#restart-services-modal .pf-v5-c-alert")

@testlib.skipImage("No security changelog support in packagekit", "arch")
@testlib.skipImage("FIXME: currently fails", "rhel-8-10")
def testInfoSecurity(self):
b = self.browser
m = self.machine
Expand Down Expand Up @@ -840,6 +841,7 @@ ExecStart=/usr/local/bin/{packageName}
b.wait_visible("table.updates-history tbody:not(.pf-m-expanded)")

@testlib.skipImage("No security changelog support in packagekit", "arch")
@testlib.skipImage("FIXME: currently fails", "rhel-8-10")
@testlib.nondestructive
def testSecurityOnly(self):
b = self.browser
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-pages
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ OnCalendar=daily
b.wait_in_text(f"#file-autocomplete-widget-preselected li:nth-of-type({i + 1}) button", paths[i])

@testlib.skipOstree("No PCP available")
@testlib.skipImage("FIXME: python3-pcp not currently on image", "rhel-8-10")
def testPlots(self):
b = self.browser
m = self.machine
Expand Down
4 changes: 4 additions & 0 deletions test/verify/check-static-login
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ account required pam_succeed_if.so user ingroup %s""" % m.get_admin_group
verify_correct(has_last=True, n_fail=0)

@testlib.skipImage("Arch Linux has no pwquality by default", "arch")
@testlib.skipImage("FIXME: does not support /etc/ssh/sshd_condfig.d", "rhel-8-10")
def testExpired(self):
m = self.machine
b = self.browser
Expand Down Expand Up @@ -354,6 +355,7 @@ account required pam_succeed_if.so user ingroup %s""" % m.get_admin_group
'.*Sorry, passwords do not match.')
self.allow_restart_journal_messages()

@testlib.skipImage("FIXME: does not support /etc/ssh/sshd_condfig.d", "rhel-8-10")
def testConversation(self):
m = self.machine
b = self.browser
Expand Down Expand Up @@ -398,6 +400,7 @@ account required pam_succeed_if.so user ingroup %s""" % m.get_admin_group

@testlib.skipImage("No tlog", "debian-*", "ubuntu-*", "arch", "centos-8-stream")
@testlib.skipOstree("No tlog")
@testlib.skipImage("FIXME: tlog messes up bridge frame protocol", "rhel-8-10")
def testSessionRecordingShell(self):
m = self.machine
b = self.browser
Expand Down Expand Up @@ -453,6 +456,7 @@ account required pam_succeed_if.so user ingroup %s""" % m.get_admin_group

@testlib.skipImage("No SELinux", "debian-*", "ubuntu-*", "arch")
@testlib.skipOstree("No semanage")
@testlib.skipImage("FIXME: Authentication failed: unknown-host", "rhel-8-10")
def testSELinuxRestrictedUser(self):
m = self.machine
b = self.browser
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-storage-anaconda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ class TestStorageAnaconda(storagelib.StorageCase):
b.wait_not_present(self.card_row("Storage", location="/var"))

@testlib.skipImage("No Stratis", "debian-*", "ubuntu-*")
@testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
def testStratis(self):
m = self.machine
b = self.browser
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-storage-luks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def console_screenshot(machine, name):


@testlib.nondestructive
@testlib.skipImage("cryptsetup uses too much memory, OOM on our test VMs", "rhel-8-*")

@martinpitt martinpitt May 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed these on main by running nond machines with more memory. t/c/run-tests has

    # on RHEL 8, provide enough RAM for cryptsetup's PBKDF (https://issues.redhat.com/browse/RHEL-8258)
    # On any newer OS, cryptsetup gets along with less RAM
    if image.startswith("rhel-8") and opts.nondestructive_memory_mb == DEFAULT_MACHINE_MEMORY_MB:
        opts.nondestructive_memory_mb = 1400

Perhaps we should backport that rather?

@allisonkarlitskaya allisonkarlitskaya May 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judgement call, and I trust your judgement :)

class TestStorageLuks(storagelib.StorageCase):

def testLuks(self):
Expand Down
2 changes: 2 additions & 0 deletions test/verify/check-storage-mounting
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ ExecStart=/usr/bin/sleep infinity
m.execute(r"sed -i '/run\/data/ s/auto.*$/auto/' /etc/fstab")
b.wait_in_text(self.card_desc(desc, "Mount point"), "/run/data (stop boot on failure)")

@testlib.skipImage("FIXME: ought to work, investigate", "rhel-8-10")
def testBadOption(self):
m = self.machine
b = self.browser
Expand Down Expand Up @@ -393,6 +394,7 @@ ExecStart=/usr/bin/sleep infinity


@testlib.nondestructive
@testlib.skipImage("cryptsetup uses too much memory, OOM on our test VMs", "rhel-8-*")
class TestStorageMountingLUKS(storagelib.StorageCase):
def testEncryptedMountingHelp(self):
m = self.machine
Expand Down
1 change: 1 addition & 0 deletions test/verify/check-storage-resize
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ class TestStorageResize(storagelib.StorageCase):
size = int(m.execute("lvs TEST/vol -o lv_size --noheading --units b --nosuffix"))
self.assertLess(size, 250000000)

@testlib.skipImage("cryptsetup uses too much memory, OOM on our test VMs", "rhel-8-*")
def testGrowShrinkEncryptedHelp(self):
m = self.machine
b = self.browser
Expand Down
2 changes: 2 additions & 0 deletions test/verify/check-storage-stratis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def create_pool_key(machine, keyname, passphrase):


@testlib.skipImage("No Stratis", "debian-*", "ubuntu-*")
@testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
@testlib.nondestructive
class TestStorageStratis(storagelib.StorageCase):
def setUp(self):
Expand Down Expand Up @@ -410,6 +411,7 @@ systemctl restart stratisd


@testlib.skipImage("No Stratis", "debian-*", "ubuntu-*")
@testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
class TestStorageStratisReboot(storagelib.StorageCase):
# LUKS uses memory hard PBKDF, 1 GiB is not enough; see https://bugzilla.redhat.com/show_bug.cgi?id=1881829
provision = {
Expand Down
8 changes: 8 additions & 0 deletions test/verify/check-storage-swap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ import testlib
@testlib.nondestructive
class TestStorageswap(storagelib.StorageCase):

def checkSwapUsed(self):
# this relies on PCP, which is missing on some images
if self.machine.image in ["debian-testing", "rhel-8-10"]:
return

self.browser.wait_text(self.card_desc("Swap", "Used"), "0 B")

def testBasic(self):
b = self.browser
m = self.machine
Expand Down Expand Up @@ -89,6 +96,7 @@ class TestStorageswap(storagelib.StorageCase):
b.wait_text(self.card_desc("Swap", "Used"), "0")
testlib.wait(lambda: "defaults" in m.execute(f"findmnt --fstab -n -o OPTIONS {disk}"))

@testlib.skipImage("cryptsetup uses too much memory, OOM on our test VMs", "rhel-8-*")
def testEncrypted(self):
b = self.browser
m = self.machine
Expand Down
Loading