branding: Include ELN branding

[jelly]

Fedora ELN has a different ID so won't match fedora's branding. Upstream this from fedora-eln-release so we can maintain and keep it up to date.

https://src.fedoraproject.org/rpms/fedora-eln-release/blob/eln/f/branding.css

Closes: #23289

[Venefilyn]

I don't like how they did the dark mode but all works fine. Also why are the two images different sizes ugh..

We can likely use SVGs instead since this is a new variant that has SVGs by default. I checked all the images and it seems like the best choice isfedora-logo-sprite.svg for both light and dark mode

❯ identify *
fedora-blacklogo-sprite.svg SVG 252x252 252x252+0+0 16-bit sRGB 7200B 0.000u 0:00.002
fedora-gdm-logo.png PNG 149x43 149x43+0+0 8-bit sRGB 2157B 0.000u 0:00.000
fedora-logo-small.png PNG 150x47 150x47+0+0 8-bit sRGB 2209B 0.000u 0:00.000
fedora-logo-sprite.png PNG 252x252 252x252+0+0 8-bit sRGB 7342B 0.000u 0:00.000
fedora-logo-sprite.svg SVG 252x252 252x252+0+0 16-bit sRGB 7187B 0.000u 0:00.001
fedora-logo.ico PNG 256x256 256x256+0+0 8-bit sRGB 7323B 0.000u 0:00.000
fedora-logo.png PNG 521x164 521x164+0+0 8-bit sRGB 6626B 0.000u 0:00.000
fedora-whitelogo-sprite.svg SVG 252x252 252x252+0+0 16-bit sRGB 6187B 0.000u 0:00.001
fedora_blacklogo.svg SVG 90x22 90x22+0+0 16-bit sRGB 6725B 0.000u 0:00.001
fedora_logo.svg SVG 90x22 90x22+0+0 16-bit sRGB 8774B 0.010u 0:00.001
fedora_logo_med.png PNG 279x80 279x80+0+0 8-bit sRGB 3687B 0.000u 0:00.000
fedora_whitelogo.svg SVG 90x22 90x22+0+0 16-bit sRGB 6632B 0.000u 0:00.001
fedora_whitelogo_med.png PNG 279x80 279x80+0+0 8-bit sRGB 2382B 0.000u 0:00.000
system-logo-white.png PNG 279x80 279x80+0+0 8-bit sRGB 2382B 0.000u 0:00.000

For reference all the logos

[Venefilyn]

I don't like how it shows ELN in the bottles then ELN next to it. Feels like it just says ELN ELN. Lets just use the icon itself as we already do the icons on other distros already

Suggested change

	ln -sTfr $(DESTDIR)/usr/share/pixmaps/fedora-logo.png $(DESTDIR)$(elnbrandingdir)/logo.png
	ln -sTfr $(DESTDIR)/usr/share/pixmaps/system-logo-white.png $(DESTDIR)$(elnbrandingdir)/logo-dark.png
	ln -sTfr $(DESTDIR)/usr/share/pixmaps/fedora-logo-sprite.svg $(DESTDIR)$(elnbrandingdir)/logo.svg

[Venefilyn]

With above suggestion to use colored logo we can get rid of dark logo

Suggested change

	.pf-v6-theme-dark #badge {
	background-image: url("logo-dark.png");
	}

[sgallagher]

As discussed in fedora-eln/eln#527, I think that the tests should also be modified to avoid this problem in the future. There will be other Fedora remixes (e.g Asahi) that will want to follow the documentation and add custom branding, but if adding such customizations causes their RPM builds of Cockpit to fail on tests, it doesn't really scale to add the branding choices upstream in Cockpit.

Edit: wrong ticket link

[yselkowitz]

Generally speaking, Fedora remixes shouldn't need to rebuild cockpit (or most other packages), but EL clones/derivatives do.

This is preventing the rebuild of cockpit for Python 3.15 in ELN, so expediting either the import of our branding or fixing the tests to ignore /etc would be appreciated. If there is something we can do to improve the branding, please let us know.

[Venefilyn]

We'll get this in for next release which will be ~June 17th

If there is something we can do to improve the branding, please let us know.

Nothing specific, just a bit strange that the ELN logo has both ELN in the icon itself and ELN as text next to it, looks weird

[Venefilyn]

I'll mark it as changes requested to improve the light and dark style with the colored SVG

[sgallagher]

I'll mark it as changes requested to improve the light and dark style with the colored SVG

Who is responsible for this change? Are you asking us to refine it?

[Venefilyn]

I'll mark it as changes requested to improve the light and dark style with the colored SVG

Who is responsible for this change? Are you asking us to refine it?

No just for Jelle in this PR, it's better to use the colored SVG for both light and dark theme instead of the colored and white PNGs.

Also I made a comment about the failing builds due to tests on ELN