Anaconda network page - #23341
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const managedWired: ListingTableRowProps[] = []; | ||
| const managedWireless: ListingTableRowProps[] = []; | ||
| let hasDetails = false; |
| }); | ||
|
|
||
| // TODO: Actions: turn on off action and edit (wired) or join wifi (wireless) | ||
| const actions = privileged && ( |
| } | ||
| ]} | ||
| isDisabled={!privileged} | ||
| /> |
| const unmanaged = []; | ||
| const plot_ifaces = []; | ||
| let hasDetails = false; | ||
| const anaconda_mode = JSON.parse(window.sessionStorage.getItem("cockpit_anaconda")); |
f3e8c6d to
1a1f051
Compare
cockpituous
left a comment
cockpituous
left a comment
There was a problem hiding this comment.
There are more than 10 code coverage comments, see the full report here.
Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
1a1f051 to
f84abff
Compare
cockpituous
left a comment
cockpituous
left a comment
There was a problem hiding this comment.
There are more than 10 code coverage comments, see the full report here.
| export const AnacondaNetworkPage = ({ privileged, operationInProgress, usage_monitor, interfaces }: AnacondaNetworkPageProps) => { | ||
| const [active, setActive] = useState<AnacondaActiveNetwork>(); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| const managedWired: ListingTableRowProps[] = []; | ||
| const managedWireless: ListingTableRowProps[] = []; | ||
| let hasDetails = false; |
There was a problem hiding this comment.
These 3 added lines are not executed by any test. Details
| const managedWireless: ListingTableRowProps[] = []; | ||
| let hasDetails = false; | ||
|
|
||
| interfaces.forEach(iface => { |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| if (is_loopback(iface)) | ||
| return; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| else if (has_group(iface)) | ||
| return; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| else if (has_group(iface)) | ||
| return; | ||
|
|
||
| const dev = iface.Device; |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| const activeConnection = render_active_connection(dev, false, true); | ||
| const isWireless = is_wireless(iface); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| let connectionStatus; | ||
| if (activeConnection) { | ||
| connectionStatus = _("Connected") |
There was a problem hiding this comment.
These 3 added lines are not executed by any test. Details
| if (activeConnection) { | ||
| connectionStatus = _("Connected") | ||
| } else { | ||
| connectionStatus = _("Disconnected") |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| const row = ( | ||
| <SimpleListItem key={iface.name} onClick={() => {setActive({isWireless, iface})}}> | ||
| <Flex | ||
| direction={{ default: 'row' }} | ||
| justifyContent={{ default: 'justifyContentSpaceBetween' }} | ||
| flexWrap={{ default: 'nowrap' }} |
There was a problem hiding this comment.
These 6 added lines are not executed by any test. Details
3 participants
Anaconda network page to simplify layout for Anaconda users.
Currently a WIP