Skip to content

feat!: remove pgx v4 wrapper and dependencies #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PascalBourdier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat!: remove pgx v4 wrapper and dependencies #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crdb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ Subpackages provide support for popular frameworks:

| Package | Framework | Import |
|---------|-----------|--------|
| `crdbpgx` | pgx v4 (standalone) | `github.com/cockroachdb/cockroach-go/v2/crdb/crdbpgx` |
| `crdbpgxv5` | pgx v5 (standalone) | `github.com/cockroachdb/cockroach-go/v2/crdb/crdbpgxv5` |
| `crdbgorm` | GORM | `github.com/cockroachdb/cockroach-go/v2/crdb/crdbgorm` |
| `crdbsqlx` | sqlx | `github.com/cockroachdb/cockroach-go/v2/crdb/crdbsqlx` |
Expand All @@ -118,7 +117,7 @@ return fmt.Errorf("failed: %w", err)
The library detects retryable errors using the `SQLState() string` method,
which is implemented by:
- [`github.com/lib/pq`](https://github.com/lib/pq) (v1.10.6+)
- [`github.com/jackc/pgx`](https://github.com/jackc/pgx) (database/sql driver mode)
- [`github.com/jackc/pgx/v5/stdlib`](https://github.com/jackc/pgx) (database/sql driver mode)

## Note for Developers

Expand Down
9 changes: 0 additions & 9 deletions crdb/crdbpgx/README.md
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions crdb/crdbpgx/pgx.go
View file
Open in desktop

This file was deleted.

100 changes: 0 additions & 100 deletions crdb/crdbpgx/pgx_test.go
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ go 1.23

require (
github.com/gofrs/flock v0.12.1
github.com/jackc/pgx/v4 v4.18.3
github.com/jackc/pgx/v5 v5.7.2
github.com/jmoiron/sqlx v1.4.0
github.com/lib/pq v1.10.9
Expand All @@ -16,17 +15,12 @@ require (

require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/jackc/chunkreader/v2 v2.0.1 // indirect
github.com/jackc/pgconn v1.14.3 // indirect
github.com/jackc/pgio v1.0.0 // indirect
github.com/jackc/pgpassfile v1.0.0 // indirect
github.com/jackc/pgproto3/v2 v2.3.3 // indirect
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
github.com/jackc/pgtype v1.14.3 // indirect
github.com/jackc/puddle v1.3.0 // indirect
github.com/jackc/puddle/v2 v2.2.2 // indirect
github.com/jinzhu/inflection v1.0.0 // indirect
github.com/jinzhu/now v1.1.5 // indirect
github.com/kr/text v0.1.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rogpeppe/go-internal v1.9.0 // indirect
golang.org/x/crypto v0.31.0 // indirect
Expand Down
Loading