ci: extract visual-regression into separate workflow with path filters#167
Merged
ci: extract visual-regression into separate workflow with path filters#167
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Test Coverage
@cocso-ui/react — File Coverage
@cocso-ui/recipe — File Coverage
@cocso-ui/codegen — File Coverage
@cocso-ui/figma — File Coverage
@cocso-ui/baseframe — File Coverage
|
Only trigger visual regression when web-related packages change (react, css, recipe, codegen, baseframe, storybook). Non-web changes like react-native-icons no longer trigger the workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hakilee
force-pushed
the
ci/visual-regression-path-filters
branch
from
6be5c7b to
d7c2bc7
Compare
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7c2bc7063
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Include packages/react-icons/** and ecosystem/icons/** in the paths filter so icon-only changes also trigger visual regression tests, since Storybook and React components consume these icons. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visual-regression.yml)로 분리paths필터 추가Test plan
packages/react,packages/css등) 변경 시 워크플로우가 트리거되는지 확인packages/react-native-icons등) 변경 시 워크플로우가 스킵되는지 확인pnpm run lint통과🤖 Generated with Claude Code