build(deps-dev): bump symplify/easy-coding-standard from 11.2.5 to 13.2.1#367
build(deps-dev): bump symplify/easy-coding-standard from 11.2.5 to 13.2.1#367dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [symplify/easy-coding-standard](https://github.com/symplify/easy-coding-standard) from 11.2.5 to 13.2.1. - [Release notes](https://github.com/symplify/easy-coding-standard/releases) - [Commits](ecsphp/ecs@11.2.5...13.2.1) --- updated-dependencies: - dependency-name: symplify/easy-coding-standard dependency-version: 13.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR attempts a major update to the coding standard tool, but it contains a critical implementation error that will prevent it from functioning. The package symplify/easy-coding-standard has been abandoned and relocated to easy-coding-standard/easy-coding-standard. The proposed changes do not update the vendor name, nor do they address the mandatory migration of the configuration file (ecs.php) to the new ECSConfig API or the requirement for PHP 8.1+. Furthermore, there is no evidence in the PR that the tool has been verified to run successfully against the codebase in its new form.
About this PR
- The PR lacks verification that the new version of the coding standard tool executes successfully against the current codebase. Please include a successful CI run or local execution logs to confirm compatibility.
Test suggestions
- Verify the coding standard check executes successfully using the new version without configuration errors.
- Verify that custom Symplify fixers (e.g., LineLengthFixer) still function correctly despite the architectural merge.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the coding standard check executes successfully using the new version without configuration errors.
2. Verify that custom Symplify fixers (e.g., LineLengthFixer) still function correctly despite the architectural merge.
Low confidence findings
- Ensure that
symplify/coding-standardis removed from your dependencies if it was previously explicitly required, as it has been merged into the main package in recent versions.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "require-dev": { | ||
| "phpunit/phpunit": "^9.0", | ||
| "symplify/easy-coding-standard": "^11.1" | ||
| "symplify/easy-coding-standard": "^13.2" |
There was a problem hiding this comment.
🔴 HIGH RISK
The package symplify/easy-coding-standard has been abandoned in favor of easy-coding-standard/easy-coding-standard. This major transition requires migrating the configuration to the new ECSConfig API and mandates PHP 8.1+. The composer.json needs to be updated to the new package identity to ensure correct dependency resolution and tool execution.
Bumps symplify/easy-coding-standard from 11.2.5 to 13.2.1.
Release notes
Sourced from symplify/easy-coding-standard's releases.
... (truncated)
Commits
678bb7aECS 13.2.1924e33aUpdated ECS to commit 36a5d8600efbd41d748167dfbe6abe4286330b3216b250cECS 13.2.0810e4c8Updated ECS to commit f252314bdd9993f7eebcfbbc5b09ee6f15d79c20e3a4d39Updated ECS to commit f0ad4abe2adb8779d71f022b5445e7c6672e2b9034f9018Updated ECS to commit 1d7815a65f0fd3d5f9533b1f5ab2c5d90251a3aa1059340Updated ECS to commit 8f72e3c42a736c80617e00b9dec3a822a1566106c83965eUpdated ECS to commit 9a00ea6cc6ed3b6db115f7e864a45bfa7ef2eb1f924ffbaUpdated ECS to commit 59e67d8f8e604e651ad8abef5e1534ca1ff2482daf5d4a2ECS 13.1.6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)