-
Notifications
You must be signed in to change notification settings - Fork 90
feat(tui): add optional message timestamps #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codeg-dev
wants to merge
15
commits into
code-yeongyu:main
Choose a base branch
from
codeg-dev:codeg-dev/tui-timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f39ee77
feat(tui): add optional message timestamps
codeg-dev 320cd5b
fix(tui): update reload timestamp test harness
codeg-dev 497eb17
fix(tui): bound and deduplicate timestamps
codeg-dev ca876b9
Merge upstream main into tui-timestamps
codeg-dev 05a1816
fix(tui): complete timestamp runtime fixture
codeg-dev 825fe82
fix(tui): cover timestamp getter in grok fixture
codeg-dev 34c06c7
fix(tui): assert timestamp reload fixture path
codeg-dev 6b88d97
Merge upstream main into tui-timestamps
codeg-dev 3b0ab56
fix(tui): preserve assistant content on timestamp toggle
codeg-dev d1e3c37
Merge upstream main into tui-timestamps
codeg-dev b21b150
Merge upstream main into tui-timestamps
codeg-dev eb921f5
Merge upstream main into tui-timestamps
codeg-dev 4c1f542
Merge upstream main into tui-timestamps
codeg-dev d6606bf
fix(tui): merge upstream main for timestamps
codeg-dev 9b0efac
docs(changelog): record optional TUI timestamps in Unreleased (#1206)
codeg-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a saved session is resumed, reloaded, or otherwise rebuilt with timestamps enabled, constructing each component immediately calls
updateContent(message), so this line stamps every historical message with the current reconstruction time and ignores the persistedmessage.timestamp. As a result, old messages display the resume/reload time—and can change again after settings-triggered transcript rebuilds—instead of a stable historical time; reconstructed components need to derive or restore a persisted arrival value while empty streaming components can continue stamping their first update.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional for the contract in #1205:
arrivedAtis the time a component first receives content in the current TUI, not the provider/model timestamp persisted on the message. Reusingmessage.timestampwould change that meaning, and the feature deliberately avoids adding persisted transcript schema. A restored or reloaded transcript is reconstructed into the current UI and receives its current UI-arrival time; live updates remain fixed byarrivedAt ??=. The regression suite locks the two-update stability contract.