fix(coding-agent): pass OSC 52 through tmux - #1211
Open
chupe wants to merge 2 commits into
Open
Conversation
Preserve both utils tracker entries and replace clipboard test timer waits with explicit native-write completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Remote clipboard writes emitted raw OSC 52. tmux could consume it without forwarding it through SSH, so
/copyand fullscreen selection reported success while the workstation clipboard stayed unchanged.Solution
Probe the effective
#{allow-passthrough}value for the current pane. When enabled, wrap OSC 52 with the existingwrapTmuxPassthrough()helper. Keep raw OSC 52 outside tmux and when passthrough is disabled or unavailable, preserving theset-clipboard onpath.Testing
npm --prefix packages/coding-agent test -- test/clipboard.test.ts(12/12)npm run checkset-clipboard onFull
npm testexceeded the 30-minute limit. The run also hit missing@earendil-works/pi-tuidist resolution underpackages/aiin the no-lifecycle checkout.Summary by cubic
Passes OSC 52 clipboard writes through tmux's DCS passthrough so remote
/copyand fullscreen selection actually reach the workstation clipboard instead of being swallowed by tmux.Changes
#{allow-passthrough}and wraps the escape sequence withwrapTmuxPassthrough()when enabled.set-clipboard onpath.Written for commit 6fb3c13. Summary will update on new commits.