Skip to content

Fix memory leak: time out unanswered get()/refresh() requests #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AloisKlingler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix memory leak: time out unanswered get()/refresh() requests #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ class TuyaDevice extends EventEmitter {
const sequenceNo = this._currentSequenceN;
// Retry up to 5 times
return pRetry(() => {
return new Promise((resolve, reject) => {
return pTimeout(new Promise((resolve, reject) => {
// Send data
this.connect().then(() => {
try {
Expand All @@ -487,6 +487,12 @@ class TuyaDevice extends EventEmitter {
}
})
.catch(error => reject(error));
}), this._responseTimeout * 2500, () => {
// On timeout, drop the pending resolver so it can't leak,
// then reject so pRetry can retry (and, once retries are
// exhausted, the caller's .catch() finally fires).
delete this._resolvers[sequenceNo];
throw new Error('Timeout waiting for response from device id: ' + this.device.id);
});
}, {
onFailedAttempt: error => {
Expand Down