fix(security): 2 improvements across 2 files#1673
Open
tomaioo wants to merge 2 commits intocogentcore:mainfrom
Open
fix(security): 2 improvements across 2 files#1673tomaioo wants to merge 2 commits intocogentcore:mainfrom
tomaioo wants to merge 2 commits intocogentcore:mainfrom
Conversation
- Security: Out-of-bounds read in Base64 decoder can panic on short input - Security: Concurrent unsynchronized error collection causes race condition Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Out-of-bounds read in Base64 decoder can panic on short input - Security: Concurrent unsynchronized error collection causes race condition Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:base/iox/imagex/base64.go:L43FromBase64indexeseb[76]without checking input length first. If attacker-controlled or malformed input shorter than 77 bytes is passed, this will panic and can be used for denial of service.Solution
Guard access with a length check before indexing (e.g.,
if len(eb) > 76 && eb[76] == ' ' { ... }). Also consider robust whitespace normalization that does not rely on fixed offsets.Changes
base/iox/imagex/base64.go(modified)cmd/changed.go(modified)