-
Notifications
You must be signed in to change notification settings - Fork 37
feat(records): aggregate endpoint #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andersfylling
wants to merge
24
commits into
master
Choose a base branch
from
andersfylling/records/aggregate-pr1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
66221d4
feat(records): add aggregate endpoint
andersfylling dd98ac8
feat(records): add aggregate helpers
andersfylling 6653552
Merge origin/master into aggregate branch
andersfylling 389eee2
fix: import ordering and docstring example for aggregate
andersfylling 119f28d
fix: import ordering in API file and exclude aggregate classes from g…
andersfylling b353db4
Merge branch 'master' into andersfylling/records/aggregate-pr1
andersfylling ce4149c
feat(records): add typed aggregate examples to docstring and exclude …
andersfylling fb9c35e
refactor(records): expose bucket aggregate buckets as a read-only pro…
andersfylling d46279c
Merge branch 'master' into andersfylling/records/aggregate-pr1
andersfylling a607d83
Update cognite/client/data_classes/data_modeling/records.py
andersfylling 12524ec
update code example
andersfylling 6c37d01
dont use sequence[str]
andersfylling 100c3c1
unroll loops for aggregate results
andersfylling 23d7777
split up responsibilities of init/load/dump
andersfylling bed39fb
remove redundant load/dump test
andersfylling 4b3d786
commit to using proper types for aggs
andersfylling 4b4bf0a
rewrite aggs
andersfylling a209fb3
cleanup the aggs examples
andersfylling aedf329
prefix records agg result types with Records
andersfylling 9935753
Merge branch 'master' into andersfylling/records/aggregate-pr1
andersfylling 04309fe
whops, re-add load support to the agg request types
andersfylling a0f7ab7
add unknown aggregate type
andersfylling 26cb596
stricter types
andersfylling 6385ad3
rename Avg => Average
andersfylling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep these out of
cognite/client/data_classes/data_modeling/__init__.pyand only in...records.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up it will be inconsistent with the other data classes that are accessible there. Do you want purely aggregate related classes, or all records/streams classes to be in their own module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've prefixed the response agg types with records, and then i moved the builder types into the records module. Do you want me to move the response types into records as well?