Skip to content

In unstable: Rename the local file override#442

Merged
mathialo merged 2 commits into
masterfrom
rename-localfile
Jun 6, 2025
Merged

In unstable: Rename the local file override#442
mathialo merged 2 commits into
masterfrom
rename-localfile

Conversation

@mathialo

@mathialo mathialo commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

-l / --local-override is renamed to -f / --force-local-config to
align with the dotnet version

Breaking changes are accepted in the unstable package.

`-l` / `--local-override` is renamed to `-f` / `--force-local-config` to
align with the dotnet version

Breaking changes are accepted in the `unstable` package.
@mathialo
mathialo requested a review from a team as a code owner June 3, 2025 10:48
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (177013a) to head (ee0ba9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files          42       42           
  Lines        3523     3523           
=======================================
  Hits         2725     2725           
  Misses        798      798           
Files with missing lines Coverage Δ
cognite/extractorutils/unstable/core/runtime.py 47.68% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathialo mathialo added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jun 4, 2025
@finnag finnag self-assigned this Jun 5, 2025
@finnag finnag added the risk-review-ongoing Risk review is in progress label Jun 5, 2025

@finnag finnag left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am missing some context here, please explain.
Where is this change used? I would expect at least something else to change somewhere for the modified argument to have an effect, or be necessary.

@finnag finnag added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jun 5, 2025
@mathialo

mathialo commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author
  • The change is in the unstable package, not used in any production extractors. It is so far only used in experiments.
  • There is nowhere in this library where usage would change since this is only a library.

@mathialo mathialo added waiting-for-risk-review Waiting for a member of the risk review team to take an action and removed waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Jun 5, 2025

@finnag finnag left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@finnag finnag added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jun 6, 2025
@mathialo
mathialo merged commit cb5f904 into master Jun 6, 2025
@mathialo
mathialo deleted the rename-localfile branch June 6, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants