Conversation
A new version of `mypy` revealed some new type errors: * we were passing nullable strings to expandvars, which does not take `None`s. The `.get` was not necessary here anyway because of the check earlier * we were ignoring the `SecretClient`, which is not necessary. It was slightly wrongly typed which probably why it was ignored.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 77.32% 77.34% +0.02%
==========================================
Files 42 42
Lines 3524 3523 -1
==========================================
Hits 2725 2725
+ Misses 799 798 -1
🚀 New features to boost your workflow:
|
mathialo
marked this pull request as ready for review
June 4, 2025 08:26
einarmo
approved these changes
Jun 4, 2025
mathialo
added
the
waiting-for-risk-review
larshagencognite
added
risk-review-ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new version of
mypyrevealed some new type errors:Nones. The.getwas not necessary here anyway because of the check earlierSecretClient, which is not necessary. It was slightly wrongly typed which probably why it was ignored.