fix: correct SaveAccount input in TestJob_ComplicatedTransfer#535
Open
Kubudak90 wants to merge 1 commit into
Open
fix: correct SaveAccount input in TestJob_ComplicatedTransfer#535Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
The test was incorrectly passing {{key.public_key}} (a *types.PublicKey)
where {{key}} (a *keys.KeyPair) was expected by SaveAccountInput.
This caused silent JSON unmarshalling failures where the KeyPair field
was populated with empty values instead of the actual key data.
Fixes coinbase#451
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #451
The test
TestJob_ComplicatedTransferwas incorrectly passing{{key.public_key}}(a*types.PublicKey) where{{key}}(a*keys.KeyPair) was expected bySaveAccountInput.The Bug
SaveAccountInputexpects:But the test was providing only the public key:
This caused silent JSON unmarshalling failures where the KeyPair field was populated with empty values instead of the actual key data, as described in #451.
The Fix
Changed
{{key.public_key}}to{{key}}to pass the full KeyPair thatGenerateKeystored in the variable.Verification
This is a one-line test fix that corrects the input data to match the expected type. The test was previously silently failing - now it will properly validate the SaveAccount functionality.
Type of Change
Testing
TestJob_ComplicatedTransferwill now properly validate SaveAccount behavior instead of silently failing during JSON unmarshalling.