Fix EncodeJSONResponse superfluous WriteHeader call#540
Open
Kubudak90 wants to merge 2 commits into
Open
Conversation
added 2 commits
April 8, 2026 02:14
The SaveAccountWorker function validates AccountIdentifier but does not validate KeyPair before passing it to StoreKey. This could cause nil pointer dereference panics if KeyPair is nil or has nil/empty fields. Add validation for: - KeyPair is not nil - KeyPair.PublicKey is not nil - KeyPair.PrivateKey is not empty This follows the same validation pattern used elsewhere in the codebase.
Fixes coinbase#407 The EncodeJSONResponse function was calling w.WriteHeader(status) before json.Encode(), which caused a superfluous WriteHeader call when encoding failed and http.Error() tried to write another header. Changes: - Encode JSON to a buffer first before writing headers - Only write status header after successful encoding - Return 500 status on encoding error without calling http.Error This prevents the 'http: superfluous response.WriteHeader call' error that occurred when JSON encoding failed.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
Problem
The
EncodeJSONResponsefunction was callingw.WriteHeader(status)beforejson.Encode(), which caused a superfluous WriteHeader call when encoding failed andhttp.Error()tried to write another header.This resulted in the error:
http: superfluous response.WriteHeader callSolution
http.ErrorChanges
bytesimportThis prevents the panic/error that occurred when JSON encoding failed after headers were already written.