fix: use {{key}} instead of {{key.public_key}} in SaveAccount test inputs#542
Open
Kubudak90 wants to merge 1 commit into
Open
fix: use {{key}} instead of {{key.public_key}} in SaveAccount test inputs#542Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
…puts
SaveAccountInput.KeyPair is of type *keys.KeyPair, not *types.PublicKey.
The test inputs were incorrectly referencing {{key.public_key}} when they
should reference {{key}} to pass the full keypair.
Fixes coinbase#451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451
Problem
The
SaveAccounttest inputs incoordinator_test.goandworker_test.gowere incorrectly referencing{{key.public_key}}for thekeypairfield. However,SaveAccountInput.KeyPairis of type*keys.KeyPair, not*types.PublicKey.Fix
Changed
{{key.public_key}}to{{key}}in all affected test inputs to pass the full keypair object, consistent with howdsl_test.goalready handles this correctly.