fix: use correct keypair variable in TestJob_ComplicatedTransfer#544
Open
Kubudak90 wants to merge 1 commit into
Open
fix: use correct keypair variable in TestJob_ComplicatedTransfer#544Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
The SaveAccount action in TestJob_ComplicatedTransfer was incorrectly
passing {{key.public_key}} to the keypair field. Since keypair expects
a KeyPair but key.public_key is a PublicKey, this caused silent
unmarshalling failure.
Change to {{key}} since the GenerateKey action stores a KeyPair at
that output path.
Fixes coinbase#451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451
The
SaveAccountaction inTestJob_ComplicatedTransferwas incorrectly passing{{key.public_key}}to thekeypairfield. Sincekeypairexpects aKeyPairbutkey.public_keyis aPublicKey, this caused silent unmarshalling failure.Change to
{{key}}since theGenerateKeyaction stores aKeyPairat that output path.