fix: add explicit engines.node >=22 to root and published packages#2654
Open
0xAxiom wants to merge 1 commit into
Open
fix: add explicit engines.node >=22 to root and published packages#26540xAxiom wants to merge 1 commit into
0xAxiom wants to merge 1 commit into
Conversation
Closes coinbase#2652. The monorepo already pins Node 22 via .nvmrc and all CI workflows test exclusively on 22.x, but the engines field was missing from package.json files. Added to the workspace root, @coinbase/onchainkit, and create-onchain so pnpm/npm warn on mismatched environments and npm search surfaces the requirement for consumers.
|
@0xAxiom is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2652.
What
Add
"engines": { "node": ">=22" }to:package.json(monorepo workspace root)packages/onchainkit/package.json(published@coinbase/onchainkit)packages/create-onchain/package.json(publishedcreate-onchainCLI)Why
The repository already enforces Node 22 through
.nvmrcand all CI workflows test exclusively on22.x. Without anenginesfield,pnpm/npmsilently allows installs on older Node versions, leading to confusing failures at runtime. Surfacing the constraint upfront:pnpm installwhen Node < 22Scope
Only the workspace root and the two published packages are included. Internal-only packages (
playground,miniapp-manifest-generator) were left unchanged since they are never installed as dependencies.