Skip to content

refactor(opencode): replace reconcile() with path-syntax setStore for streaming updates #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coleleavitt wants to merge 4 commits into
base: dev
Choose a base branch
from
+72 −30
Open

refactor(opencode): replace reconcile() with path-syntax setStore for streaming updates #3

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56e7057
perf(tui): replace reconcile() with path-syntax setStore for streamin…
coleleavitt Feb 27, 2026
6ba24a4
fix(tui): address PR review — restore reconcile for dict stores, fix …
coleleavitt Feb 27, 2026
7371b81
perf(tui): coalesce streaming deltas via queueMicrotask to eliminate …
coleleavitt Feb 27, 2026
f2a3e23
fix(tui): guard flushDeltas against post-unmount execution to prevent…
coleleavitt Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 25 additions & 28 deletions packages/opencode/src/cli/cmd/tui/context/sync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type {
ProviderAuthMethod,
VcsInfo,
} from "@opencode-ai/sdk/v2"
import { createStore, produce, reconcile } from "solid-js/store"
import { createStore, produce } from "solid-js/store"
import { useSDK } from "@tui/context/sdk"
import { Binary } from "@opencode-ai/util/binary"
import { createSimpleContext } from "./helper"
Expand Down Expand Up @@ -134,7 +134,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
}
const match = Binary.search(requests, request.id, (r) => r.id)
if (match.found) {
setStore("permission", request.sessionID, match.index, reconcile(request))
setStore("permission", request.sessionID, match.index, request)
break
}
setStore(
Expand Down Expand Up @@ -172,7 +172,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
}
const match = Binary.search(requests, request.id, (r) => r.id)
if (match.found) {
setStore("question", request.sessionID, match.index, reconcile(request))
setStore("question", request.sessionID, match.index, request)
break
}
setStore(
Expand Down Expand Up @@ -208,7 +208,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
case "session.updated": {
const result = Binary.search(store.session, event.properties.info.id, (s) => s.id)
if (result.found) {
setStore("session", result.index, reconcile(event.properties.info))
setStore("session", result.index, event.properties.info)
break
}
setStore(
Expand All @@ -233,7 +233,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
}
const result = Binary.search(messages, event.properties.info.id, (m) => m.id)
if (result.found) {
setStore("message", event.properties.info.sessionID, result.index, reconcile(event.properties.info))
setStore("message", event.properties.info.sessionID, result.index, event.properties.info)
break
}
setStore(
Expand Down Expand Up @@ -286,7 +286,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
}
const result = Binary.search(parts, event.properties.part.id, (p) => p.id)
if (result.found) {
setStore("part", event.properties.part.messageID, result.index, reconcile(event.properties.part))
setStore("part", event.properties.part.messageID, result.index, event.properties.part)
break
}
setStore(
Expand All @@ -307,12 +307,9 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
setStore(
"part",
event.properties.messageID,
produce((draft) => {
const part = draft[result.index]
const field = event.properties.field as keyof typeof part
const existing = part[field] as string | undefined
;(part[field] as string) = (existing ?? "") + event.properties.delta
}),
result.index,
event.properties.field as any,
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great performance optimization. However, the use of as any weakens type safety. While it can be difficult to correctly type dynamic paths with Solid's setStore, it's good practice to avoid any if possible.

If a more specific type isn't feasible, I suggest adding a comment to explain why as any is used. This will help future maintainers understand the code.

            event.properties.field as any, // Using 'as any' as TypeScript struggles with dynamic paths in `setStore`.

(prev: string) => (prev ?? "") + event.properties.delta,
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. event.properties.field cast to any 📘 Rule violation ⛨ Security

The updated setStore() call casts event.properties.field to any, reducing type safety and
allowing arbitrary store-path writes. This can mask bugs and weakens validation of
externally-sourced event data.
Agent Prompt 
## Issue description
The PR introduces `event.properties.field as any` in a `setStore()` path segment, which violates the no-`any` requirement and allows arbitrary property/path updates from event data.

## Issue Context
This code runs on streaming updates (`message.part.delta`). The field name originates from `event.properties.field`, which should be treated as untrusted/variable input unless it is provably constrained by types/runtime checks.

## Fix Focus Areas
- packages/opencode/src/cli/cmd/tui/context/sync.tsx[310-312]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

)
break
}
Expand Down Expand Up @@ -388,31 +385,31 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
const sessions = responses[4]

batch(() => {
setStore("provider", reconcile(providers.providers))
setStore("provider_default", reconcile(providers.default))
setStore("provider_next", reconcile(providerList))
setStore("agent", reconcile(agents))
setStore("config", reconcile(config))
if (sessions !== undefined) setStore("session", reconcile(sessions))
setStore("provider", providers.providers)
setStore("provider_default", providers.default)
setStore("provider_next", providerList)
setStore("agent", agents)
setStore("config", config)
if (sessions !== undefined) setStore("session", sessions)
})
})
})
.then(() => {
if (store.status !== "complete") setStore("status", "partial")
// non-blocking
Promise.all([
...(args.continue ? [] : [sessionListPromise.then((sessions) => setStore("session", reconcile(sessions)))]),
sdk.client.command.list().then((x) => setStore("command", reconcile(x.data ?? []))),
sdk.client.lsp.status().then((x) => setStore("lsp", reconcile(x.data!))),
sdk.client.mcp.status().then((x) => setStore("mcp", reconcile(x.data!))),
sdk.client.experimental.resource.list().then((x) => setStore("mcp_resource", reconcile(x.data ?? {}))),
sdk.client.formatter.status().then((x) => setStore("formatter", reconcile(x.data!))),
...(args.continue ? [] : [sessionListPromise.then((sessions) => setStore("session", sessions))]),
sdk.client.command.list().then((x) => setStore("command", x.data ?? [])),
sdk.client.lsp.status().then((x) => setStore("lsp", x.data!)),
sdk.client.mcp.status().then((x) => setStore("mcp", x.data!)),
sdk.client.experimental.resource.list().then((x) => setStore("mcp_resource", x.data ?? {})),
sdk.client.formatter.status().then((x) => setStore("formatter", x.data!)),
sdk.client.session.status().then((x) => {
setStore("session_status", reconcile(x.data!))
setStore("session_status", x.data!)
}),
sdk.client.provider.auth().then((x) => setStore("provider_auth", reconcile(x.data ?? {}))),
sdk.client.vcs.get().then((x) => setStore("vcs", reconcile(x.data))),
sdk.client.path.get().then((x) => setStore("path", reconcile(x.data!))),
sdk.client.provider.auth().then((x) => setStore("provider_auth", x.data ?? {})),
sdk.client.vcs.get().then((x) => setStore("vcs", x.data)),
sdk.client.path.get().then((x) => setStore("path", x.data!)),
]).then(() => {
setStore("status", "complete")
})
Expand Down
Loading