Skip to content

Add GHA build - #388

Open
gliptak wants to merge 1 commit into
comby-tools:masterfrom
gliptak:actions1
Open

Add GHA build#388
gliptak wants to merge 1 commit into
comby-tools:masterfrom
gliptak:actions1

Conversation

@gliptak

@gliptak gliptak commented May 24, 2025

Copy link
Copy Markdown

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak

gliptak commented May 28, 2025

Copy link
Copy Markdown
Author

@rvantonder please review

1 similar comment
@gliptak

gliptak commented Jun 22, 2025

Copy link
Copy Markdown
Author

@rvantonder please review

@gliptak

gliptak commented Jul 17, 2025

Copy link
Copy Markdown
Author

@rvantonder have you had a chance to work this?

@rvantonder

Copy link
Copy Markdown
Member

Hey @gliptak I did try I need to update the base image (and push it to docker) and ran into an issue. I'll check in again in some time this week. I wish I could do things a bit faster, busy!

@gliptak

gliptak commented Sep 30, 2025

Copy link
Copy Markdown
Author

@rvantonder please provide next steps

@rvantonder

rvantonder commented Oct 3, 2025

Copy link
Copy Markdown
Member

Thanks @gliptak.

I can add this but it's just going to build the base image and not push it to Docker, which is what's really needed to do an actual Docker release. It might help flag issues with e.g., #379 -- for that I still had issues building locally, and it's dependent on pushing up the base dep image for Docker. So even if this GH build succeeds, I still need it to build manually and then push the image upstream (I don't want to have to manage secrets with GH build to push to Docker on every push, that's kind of too much hassle for me to maintain--the Dockerfile is there as a DIY solution if folks want to use Docker, so it is best if I just update it manually locally with my credentials).

Let me see if I can merge #379, I will try build the base image and push up to Docker first.

@gliptak

gliptak commented Oct 3, 2025

Copy link
Copy Markdown
Author

thank you @rvantonder consider publishing to ghcr.io which doesn't require additional credentials (like https://github.com/gliptak/aws-cdk-python/pkgs/container/aws-cdk-python) I'm open to submit a followup PR implementing

@gliptak

gliptak commented Jan 23, 2026

Copy link
Copy Markdown
Author

@rvantonder please provide next steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants