Skip to content

VW MLB: longitudinal support for cars on ACC_01 - #3707

Draft
oscarmcnulty wants to merge 3 commits into
commaai:masterfrom
oscarmcnulty:vw-mlb-long-nodep
Draft

VW MLB: longitudinal support for cars on ACC_01#3707
oscarmcnulty wants to merge 3 commits into
commaai:masterfrom
oscarmcnulty:vw-mlb-long-nodep

Conversation

@oscarmcnulty

@oscarmcnulty oscarmcnulty commented Aug 24, 2026

Copy link
Copy Markdown

Add longitudinal support for the subset of MLB cars that use ACC_01 for long control.

  • Longitudinal requires stock ACC as ECU has a latching fault if ACC_01 isn't sent shortly after key on. Basic CC does not send this message.
  • There is a hard minimum speed of 15kph observed. (stock ACC has a min engage speed of ~25kph and disengages about ~16kph).
  • Max deceleration is limited to -2.95m/s^2. There is a fault thrown when the deceleration command is -3.0 for ~5 frames in testing so -2.95 gives some buffer. Example fault 15e6fc3f7f90b0c5/00000178--9cb7aaf2a4/40.
  • Switch to MO_BLS is necessary to prevent faults as MO_Fahrer_bremst has significantly higher delay and ECU throws a latching fault when ACC is commanded while braking is happening.

MLB cars that use the ACC_05 message (Porsche Macan) are not covered in this PR but should be supportable in a very similar way with full stop-and-go functionality possible.

TODO: Validation route

Validation

  • Dongle ID:
  • Route:

@github-actions github-actions Bot added car related to opendbc/car/ volkswagen car safety vehicle-specific safety code labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Car behavior report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

Testing 130 segments for: VOLKSWAGEN_ARTEON_MK1, VOLKSWAGEN_ATLAS_MK1, VOLKSWAGEN_CRAFTER_MK2, VOLKSWAGEN_GOLF_MK7, VOLKSWAGEN_JETTA_MK7, VOLKSWAGEN_PASSAT_MK8, VOLKSWAGEN_PASSAT_NMS, VOLKSWAGEN_POLO_MK6, VOLKSWAGEN_TAOS_MK1, VOLKSWAGEN_TIGUAN_MK2, VOLKSWAGEN_TOURAN_MK2, VOLKSWAGEN_TRANSPORTER_T61, VOLKSWAGEN_TROC_MK1

✅ 0 changed, 130 passed, 0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code car related to opendbc/car/ DBC signals volkswagen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants