Skip to content

Tesla: remove stale HW3 TODO - #3708

Open
nikitap066 wants to merge 1 commit into
commaai:masterfrom
nikitap066:tesla-hw3-todo
Open

Tesla: remove stale HW3 TODO#3708
nikitap066 wants to merge 1 commit into
commaai:masterfrom
nikitap066:tesla-hw3-todo

Conversation

@nikitap066

Copy link
Copy Markdown
Contributor

2017 Model 3s shipped with HW2/HW2.5, not HW3 (HW3 rollout began ~April 2019, VINs 332xxx+). Current "2019-23" range is correct as-is; no doc string change needed.

Removes the TODO - no functional behaviour change.

Validation
Dongle ID: N/A
Route: N/A

@github-actions github-actions Bot added car related to opendbc/car/ tesla labels Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Car behavior report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

Testing 20 segments for: TESLA_MODEL_3, TESLA_MODEL_Y

⚠️ 20 changed, 0 passed, 0 errors

Show changes

TESLA_MODEL_3 - 3b747326f67476fc/00000003--be5f7dfd59/10

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - cb4d3c4cf8205224/00000044--6e75fc53fd/4

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - fa2c6a0d5a103101/00000000--b3524905e8/1

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - 3ae5e3d7179aa92c/0000004b--ec90b6e6c7/2

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - d04e7fec899dc4dd/00000030--d6581df6db/10

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - fa2c6a0d5a103101/00000007--3786dc087a/9

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - 063c5f30b8e68fae/0000002a--62f52256c4/63

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - 530075d26cad58e4/0000002e--f6a5b83bdf/7

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - c0fe59cc1ebbd1b3/00000005--5ec51e6635/18

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_3 - d2ef70a79f9aedf8/00000048--e5a1dee61f/60

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 1d7097acc16c1927/00000002--96eeb0ec9e/2

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 2c912ca5de3b1ee9/000002ca--b6db903149/16

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 2a5a0210bcc9b83b/00000026--88e8f288bf/18

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 6946cfaf6ba995e3/00000089--85221cc482/4

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 2405af2b4d613483/00000011--19fd216868/14

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - cb4d3c4cf8205224/0000000b--2b46c03b39/13

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 1d7097acc16c1927/00000002--96eeb0ec9e/17

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - d88fe5d919f6ec47/00000004--641726945a/3

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - 7588270b74f42d15/0000005e--a984e0529a/8

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

TESLA_MODEL_Y - da74b4dc7cea694c/00000018--c54ec37f9e/2

  carParams.longitudinalTuning.kpBP (1 diffs)
    frame -1: [0.0] -> None

  carParams.longitudinalTuning.kpV (1 diffs)
    frame -1: [0.0] -> None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car related to opendbc/car/ tesla

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant