hyundai: match stock longitudinal button behavior - #3719
Open
NSK-syam wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
car
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 260 segments for: HYUNDAI_AZERA_HEV_6TH_GEN, HYUNDAI_ELANTRA_GT_I30, HYUNDAI_ELANTRA_2021, HYUNDAI_ELANTRA_HEV_2021, HYUNDAI_GENESIS, HYUNDAI_IONIQ, HYUNDAI_IONIQ_HEV_2022, HYUNDAI_IONIQ_EV_2020, HYUNDAI_IONIQ_PHEV_2019, HYUNDAI_IONIQ_PHEV, HYUNDAI_KONA_2022, HYUNDAI_KONA_EV, HYUNDAI_KONA_EV_2022, HYUNDAI_KONA_EV_2ND_GEN, HYUNDAI_SANTA_FE, HYUNDAI_SANTA_FE_2022, HYUNDAI_SANTA_FE_HEV_2022, HYUNDAI_SANTA_FE_PHEV_2022, HYUNDAI_SONATA, HYUNDAI_SONATA_LF, HYUNDAI_STARIA_4TH_GEN, HYUNDAI_PALISADE, HYUNDAI_SONATA_HYBRID, HYUNDAI_IONIQ_5, HYUNDAI_IONIQ_6, HYUNDAI_TUCSON_4TH_GEN, HYUNDAI_SANTA_CRUZ_1ST_GEN, HYUNDAI_CUSTIN_1ST_GEN Show changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of commaai/openpilot#30950.
Matches Hyundai's stock longitudinal button behavior in both the car interface and panda safety:
Validation
ff973b941a69366f|2022-07-28--22-01-19--11— Kona EV 2022: code 4 resumed the stored 60 km/h speed after disable656ac0d830792fcc|2021-12-28--14-45-56--1— Santa Fe PHEV 2022: code 4 resumed the stored 32.2 km/h speedf0709d2bc6ca451f|2022-10-15--08-13-54--0— Santa Cruz: first MAIN enabled cruise; code 4 paused it05a8f0197fdac372|2022-10-19--14-14-09--0— Ioniq 5: first MAIN enabled cruise; code 4 paused it68d6a96e703c00c9|2022-09-10--16-09-39--0— Kia EV6: code 4 repeatedly toggled stock cruiseca4de5b12321bd98|2022-10-18--21-15-59--0— Genesis GV70: first MAIN enabled cruiseb5d6dc830ad63071|2022-12-12--21-28-25--12— Genesis GV60 control: ordinary RES/SET eventsTests
The small openpilot-side set-speed preservation change will be submitted as a dependent PR.