Peugeot 308 T9 (2018): add dashcam-only support - #3731
Draft
polo2169 wants to merge 1 commit into
Draft
Conversation
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. ✅ No changes detected |
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial dashcam-only support for the 2018 Peugeot 308 II T9 (facelift),
based on captures from one vehicle with conventional cruise control. The T9
uses a dedicated receive-only DBC and CarState instead of the existing PSA R3
signal mapping. Identification uses the observed CAN ID/DLC fingerprint.
The platform is
dashcamOnlywithSafetyModel.noOutput, longitudinal controldisabled, and a controller that returns no CAN messages and zero applied
actuators regardless of requested activation. This does not change openpilot's
generic firmware-query stage before car identification. There are no new safety
hooks, actuation messages, HIL profiles or experimental control gains.
The DBC contains ten messages needed for vehicle state. PSA checksum seeds are
extended for the observed
0x3ADand0x3CDprotections. Two two-second RXfixtures (2,260 frames) retain original payloads and relative timing; provenance
and hashes are included. The export excludes VIN, GPS, diagnostic traffic and
session metadata. Complete-source fingerprint checks covered 830,342 RX live
frames across the two captures, with no ID/DLC mismatch after excluding OBD
diagnostic IDs.
This is an early draft for review of the decoding and port structure. No comma
route is available yet; the platform is explicitly listed in
non_tested_carsuntil one is supplied. The physical comma harness/bus mapping, firmware
fingerprinting and vehicle geometry still need validation. Driver torque is
in raw units. The forward/Park/Neutral gear field is omitted because the former
candidate in
0x348remains zero even in the moving capture. Only the independentreverse indication is decoded. Lateral parameters are inert placeholders, not
an EPS calibration. Coverage is limited to the reference 2018 configuration.
Validation
suites. Covers T9 replay and no-output behavior, all car interfaces, CAN
fingerprints, docs/platforms/routes, lateral limits, CAN parsing/checksums,
existing PSA safety and default safety modes.
repeated counters, wrong bus, stream expiry, and all activation combinations
with and without received CAN.
ruff check .,ty check,codespell,uv lock --check, andgit diff --checkpassed. Generateddocs/CARS.mdis included.853001dc: Linux/macOS./test.sh, safety,safety mutation tests on both platforms, all four model-test groups and car
diff. The car behavior report detected no changes to existing routes.