Chrysler: match firmware revisions with required control ECU evidence - #3739
Open
khchen428 wants to merge 1 commit into
Open
Chrysler: match firmware revisions with required control ECU evidence#3739khchen428 wants to merge 1 commit into
khchen428 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 40 segments for: CHRYSLER_PACIFICA_2018_HYBRID, CHRYSLER_PACIFICA_2019_HYBRID, CHRYSLER_PACIFICA_2018, CHRYSLER_PACIFICA_2020 ✅ 0 changed, 40 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #3733 to submit this work from khchen428. The code and commits are unchanged.
The validation described below applies to these unchanged commits and includes results from the original PR. CI for this replacement PR is pending.
Recognize unseen Chrysler firmware revisions by matching the complete eight-character part number while ignoring its two-letter software revision. Require the candidate's known EPS, ABS, radar, and SRS parts, preserve exact matching for opaque radar responses, and tolerate one missing or previously unknown cluster part when other expected modules match. Known conflicting cluster parts and ambiguous candidates remain rejected.
Add a default-on
use_generic_fuzzyoption and disable it for Chrysler: otherwise generic matching can accept a vehicle from other ECUs before the custom matcher checks unknown or missing control-module firmware. A public-entry regression test demonstrates this bypass and verifies the opt-out. Existing brands retain their current behavior.Validation:
./test.shpasses: 3,986 tests run, 3,294 passed and 692 skipped; Ruff, ty, codespell, cpplint, and MISRA pass.ZZ, proposed matching preserves those 63 matches; baseline matches none.Dataset revision:
edb6480d0e0b5775fde7150c01bcdd5b78d0ad32; historical database:fe27b134350c44724aa2078de12d1c447f8e3083. No hardware was used.Related to #1092. New control-module part numbers still require validation and database updates; this does not claim to identify every future compatible model.