[Stack 8/27] Deep analysis of Python-Clojure discrepancies and fix plan#2419
Closed
jucor wants to merge 7 commits intojc/uv-pip-cifrom
Closed
[Stack 8/27] Deep analysis of Python-Clojure discrepancies and fix plan#2419jucor wants to merge 7 commits intojc/uv-pip-cifrom
jucor wants to merge 7 commits intojc/uv-pip-cifrom
Conversation
This was referenced Mar 5, 2026
jucor
force-pushed
the
jc/kmeans_clustering_tooling
branch
from
e35f31a to
ad8a92c
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
74d276e to
cda5015
Compare
jucor
force-pushed
the
jc/kmeans_clustering_tooling
branch
from
ad8a92c to
00c659e
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
cda5015 to
f4136dd
Compare
jucor
force-pushed
the
jc/kmeans_clustering_tooling
branch
from
00c659e to
69cf22e
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
f4136dd to
d965abb
Compare
jucor
force-pushed
the
jc/kmeans_clustering_tooling
branch
from
69cf22e to
ecebe3b
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
d965abb to
3886fb5
Compare
jucor
force-pushed
the
jc/kmeans_clustering_tooling
branch
from
ecebe3b to
ea26a44
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
3886fb5 to
000bb0a
Compare
3 tasks
jucor
changed the base branch from
jc/kmeans_clustering_tooling
to
jc/participant-id-unfolding
jucor
changed the title
jucor
changed the title
5 tasks
jucor
changed the title
jucor
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only PR capturing a deep, statement-by-statement analysis of Python vs Clojure math pipeline discrepancies and a proposed TDD plan to bring Python to parity, plus consolidating Delphi’s CLAUDE.md guidance.
Changes:
- Add
deep-analysis-for-julien/docs describing discrepancies across PCA, clustering, repness, participant filtering, and comment routing. - Add a prioritized, PR-by-PR TDD execution plan in
delphi/docs/PLAN_DISCREPANCY_FIXES.md. - Update
delphi/CLAUDE.mdto consolidate documentation pointers and add testing/regression guidance.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| delphi/docs/PLAN_DISCREPANCY_FIXES.md | Concrete staged plan for discrepancy-driven TDD fixes and verification workflow. |
| delphi/CLAUDE.md | Consolidates Delphi doc guidance; adds a testing/regression overview. |
| deep-analysis-for-julien/01-overview-and-architecture.md | High-level architecture and data-flow overview across Python/Clojure implementations. |
| deep-analysis-for-julien/02-pca-analysis.md | PCA implementation comparison and sources of divergence. |
| deep-analysis-for-julien/03-clustering-analysis.md | Clustering/k-selection comparison (incl. k-smoother) and format notes. |
| deep-analysis-for-julien/04-repness-analysis.md | Repness math comparison and discrepancy breakdown. |
| deep-analysis-for-julien/05-participant-filtering.md | In-conv filtering + comment priorities/vote structures comparison. |
| deep-analysis-for-julien/06-comment-routing.md | TypeScript comment routing analysis and dependency on comment-priorities. |
| deep-analysis-for-julien/07-discrepancies.md | Canonical list of all identified discrepancies with severity and locations. |
| deep-analysis-for-julien/08-dead-code.md | Inventory of dead/unreachable code and known issues. |
| deep-analysis-for-julien/09-fix-plan.md | Prioritized fix plan and phased rollout guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jucor
changed the title
jucor
changed the title
jucor
changed the title
jucor
force-pushed
the
jc/participant-id-unfolding
branch
from
b2f145d to
48afbe4
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
000bb0a to
f323584
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
6c3dc7b to
839b3c7
Compare
jucor
force-pushed
the
jc/cold-start-tooling
branch
2 times, most recently
from
130a7b8 to
16fd44b
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
839b3c7 to
11831d4
Compare
2 tasks
jucor
changed the title
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
11831d4 to
2d235be
Compare
jucor
force-pushed
the
jc/cold-start-tooling
branch
from
16fd44b to
1fe0cfa
Compare
jucor
changed the title
jucor
force-pushed
the
jc/cold-start-tooling
branch
from
1fe0cfa to
e74ff24
Compare
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
2d235be to
b979d12
Compare
4 tasks
Comprehensive 9-document analysis covering: - Architecture and data flow comparison - PCA implementation details (power iteration vs SVD) - Two-level clustering with k-smoother analysis - Representativeness metrics with formula verification - Participant filtering and comment priority systems - TypeScript comment routing (prioritized vs topical) - 15 identified discrepancies rated by severity - Dead code inventory across Python codebase - Prioritized fix plan to bring Python to Clojure parity Key findings: 5 CRITICAL discrepancies (in-conv threshold, proportion test formula, repness metric, z-score thresholds, missing comment priorities), 3 HIGH, and 7 MEDIUM/LOW. https://claude.ai/code/session_01FEPFmVHKz1eoqzvXSTmu14
- Doc 02: Correct Clojure sparsity-aware projection code to match actual implementation (raw votes with nils skipped, not imputed). Add new discrepancy D1b documenting subtle projection input difference. - Doc 03: Fix same-clustering convergence check description - it checks every pairwise distance < threshold, not sum. - Doc 07: Add D1b projection input discrepancy (LOW severity). https://claude.ai/code/session_01FEPFmVHKz1eoqzvXSTmu14
- Remove AGENTS.md and CLAUDE.md/GEMINI.md symlinks - Create delphi/CLAUDE.md as a real file with upstream content plus testing, regression, and sklearn migration sections - Add outdated docs warning - Move uv-specific instructions to CLAUDE.local.md (gitignored) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lien into delphi/docs/ - Move deep-analysis-for-julien/ from repo root to delphi/docs/ - Fix broken reference to 09-fix-plan.md (now relative path) - Fix double period in plan doc - Fix Pre-requisite → Prerequisite - Canonicalize journal filename to CLJ-PARITY-FIXES-JOURNAL.md - Add note in 09-fix-plan.md that canonical ordering is in PLAN_DISCREPANCY_FIXES.md - Replace 'adequate command line flag' with '--include-local' in CLAUDE.md - Add 'start here' pointer to trusted docs in CLAUDE.md warning - Annotate extremtiy as intentional (matches Clojure source typo)
jucor
force-pushed
the
jc/kmeans_analysis_docs
branch
from
b979d12 to
fa0395b
Compare
Delphi Coverage Report
|
This was referenced Mar 30, 2026
Collaborator
Author
|
Superseded by spr-managed PR stack. See the new stack starting at #2508. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only PR: deep analysis of Python vs Clojure discrepancies and a TDD fix plan.
Changes
deep-analysis-for-julien/) comparing Python and Clojure implementations statement-by-statementdocs/PLAN_DISCREPANCY_FIXES.md) with prioritized list of fixesTest plan
🤖 Generated with Claude Code