Skip to content

[Stack 2/17] Add SKIP_GOLDEN env var to disable golden snapshot tests #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jucor wants to merge 1 commit into
base: spr/edge/1a8eb714
Choose a base branch
from
Open

[Stack 2/17] Add SKIP_GOLDEN env var to disable golden snapshot tests #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
-e POSTGRES_HOST=postgres \
-e POSTGRES_PASSWORD=PdwPNS2mDN73Vfbc \
-e POSTGRES_DB=polis-test \
-e SKIP_GOLDEN=1 \
delphi \
bash -c " \
set -e; \
Expand Down
9 changes: 9 additions & 0 deletions delphi/tests/test_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,19 @@
pytest tests/test_regression.py --include-local # Include local datasets
"""

import os

import pytest
import numpy as np

from polismath.regression import ConversationRecorder, ConversationComparer
from polismath.regression.utils import load_golden_snapshot

_skip_golden = pytest.mark.skipif(
os.environ.get("SKIP_GOLDEN") == "1",
reason="Golden snapshot tests disabled (SKIP_GOLDEN=1)",
)


def _check_golden_exists(dataset_name: str):
"""
Expand All @@ -44,6 +51,7 @@ def _check_golden_exists(dataset_name: str):
)


@_skip_golden
@pytest.mark.use_discovered_datasets
def test_conversation_regression(dataset_name):
"""
Expand Down Expand Up @@ -91,6 +99,7 @@ def test_conversation_regression(dataset_name):
)


@_skip_golden
@pytest.mark.use_discovered_datasets
def test_conversation_stages_individually(dataset_name):
"""
Expand Down
Loading