Skip to content

fix(remix): make checkbox styles value-comparable #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoafarias merged 1 commit into from
Aug 9, 2026
Merged

fix(remix): make checkbox styles value-comparable #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/remix/lib/src/components/checkbox/checkbox_style.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
part of 'checkbox.dart';

final _onIndeterminateVariant = ContextVariant(
'on_indeterminate',
(context) => NakedCheckboxState.maybeOf(context)?.isChecked == null,
);

/// Style configuration for [RemixCheckbox] container and indicator icon.
extension RemixCheckboxStylerRemixHelpers on CheckboxStyler {
/// Sets indicator color.
Expand All @@ -8,13 +13,7 @@ extension RemixCheckboxStylerRemixHelpers on CheckboxStyler {
}

CheckboxStyler onIndeterminate(CheckboxStyler value) {
return variant(
ContextVariant(
'on_indeterminate',
(context) => NakedCheckboxState.maybeOf(context)?.isChecked == null,
),
value,
);
return variant(_onIndeterminateVariant, value);
}

/// Sets checkbox fill color on the container.
Expand Down
12 changes: 12 additions & 0 deletions packages/remix_fortal/test/components/checkbox/checkbox_style_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:remix_fortal/remix_fortal.dart';

void main() {
test('same arguments produce equal styles', () {
final first = fortalCheckboxStyle();
final second = fortalCheckboxStyle();

expect(first, equals(second));
expect(first.hashCode, equals(second.hashCode));
});
}
Loading