Entrega desafio android Eduardo Urzua.#140
Open
eduardourzuap wants to merge 22 commits into
Open
Conversation
Creación Activity
Inclusion Lista de repositorios.
Modificacion Progress Bar
Error en adapter
Revisar problema de attached adapter
Inyeccion de dependencias
Modificacion repo sin llamada
Modificacion adapter repos
Modificacion a api correcta
Modificacion Coil
Modificacion de vistar y fragments
falta validaciones,try catch, search, menus...
Comentado el searchview por caida
Prueba de conceptoo de room para insertar REPOS.
Modificacion de mapeo
Validaciones Basicas
Inicio de Test Unitarios
Test ViewModel...se respalda esperando sync gradle
Se agregan test Basicos
Se cambia progressbar por shimmer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sobre você
Nome: Eduardo Urzua
Sede(s) que gostaria de trabalhar (SP, RJ, PE, BH): Santiago Chile
Gostaria de receber feedback sobre seu desafio? (sim/não): Si
Alguma consideração sobre o seu projeto?
Buenas,
No logre implementar correctamente el feature del número de página, ya que la lógica de búsqueda mediante el searchview no me quedo bien implementada y al momento de renovar repositorios vía api la app se caia por null con el error ApiService$searchRepositories$2.invokeSuspend(ApiService.kt:17) por lo cual quedo incompleto y comentado en el código.
Además, intente abrir el navegador con el pull request seleccionado desde el findNavController y no me funciono, ya que daba error porque el destino no existía en el navgraph, si pude hacerlo funcionar vía intent.