Skip to content

[WIP] Update pin for pytorch - #5123

Merged
hmaarrfk merged 1 commit into
conda-forge:mainfrom
regro-cf-autotick-bot:new_pin-pytorch-2.1-0-_hbf2599
Nov 13, 2023
Merged

[WIP] Update pin for pytorch#5123
hmaarrfk merged 1 commit into
conda-forge:mainfrom
regro-cf-autotick-bot:new_pin-pytorch-2.1-0-_hbf2599

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update the pin for pytorch. The current pinned version is 2.0, the latest available version is 2.1 and the max pin pattern is x.x. This migration will impact 33 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 2.0 to 2.1.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping pytorch-cpu
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6778568921, please use this URL for debugging

@regro-cf-autotick-bot
regro-cf-autotick-bot requested a review from a team as a code owner November 7, 2023 02:48
@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/pytorch-cpu and so here I am doing that.

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off here. We are still working through some kinks with these packages in the feedstock: conda-forge/pytorch-cpu-feedstock#203

@jakirkham
jakirkham marked this pull request as draft November 7, 2023 02:54
@jakirkham jakirkham changed the title Update pin for pytorch [WIP] Update pin for pytorch Nov 7, 2023
@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/pytorch-cpu and so here I am doing that.

@hmaarrfk
hmaarrfk marked this pull request as ready for review November 13, 2023 03:30
@hmaarrfk

Copy link
Copy Markdown
Contributor

Kinks have been worked out ^_^

@hmaarrfk
hmaarrfk merged commit b4e7e4f into conda-forge:main Nov 13, 2023
@regro-cf-autotick-bot
regro-cf-autotick-bot deleted the new_pin-pytorch-2.1-0-_hbf2599 branch November 13, 2023 03:37
@jakirkham

Copy link
Copy Markdown
Member

Thanks Mark! 🥳

@hmaarrfk

Copy link
Copy Markdown
Contributor

i feel like i'm getting clashes between torchvision and pytroch for cuda 11.2 and 11.8. is this a problem for other packages too? or just for pytorch related packages?

@jakirkham

jakirkham commented Nov 13, 2023

Copy link
Copy Markdown
Member

Maybe we should start an issue somewhere with more details?

Edit: Perhaps on the torchvision feedstock?

Edit 2: Also curious if this PR helped ( conda-forge/torchvision-feedstock#81 )

@hmaarrfk

Copy link
Copy Markdown
Contributor

I think that the PR that helped was: conda-forge/torchvision-feedstock#80

and perhaps if I ever get around to finishing:
conda-forge/conda-forge-repodata-patches-feedstock#589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants