Skip to content

Fix for cuda_compiler_version not found on local builds - #42

Closed
mmcauliffe wants to merge 2 commits into
conda-forge:mainfrom
mmcauliffe:fix-local-windows
Closed

Fix for cuda_compiler_version not found on local builds#42
mmcauliffe wants to merge 2 commits into
conda-forge:mainfrom
mmcauliffe:fix-local-windows

Conversation

@mmcauliffe

@mmcauliffe mmcauliffe commented Jul 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices

conda-forge-webservices Bot commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mmcauliffe

mmcauliffe commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Resolves #41

h-vetinari
h-vetinari reviewed Jul 28, 2023
View reviewed changes
Comment thread recipe/meta.yaml
number: 1
# Bug in for cuda 11.1 with c++17 on linux: https://forums.developer.nvidia.com/t/nvc-20-9-fails-to-compile-code-instantiating-any-std-tuple-with-gcc-10-2-on-c-17/160987
skip: true # [cuda_compiler_version == "10.2" or (linux and cuda_compiler_version == "11.1")]
skip: true # [cuda_compiler_version == "12.0" or cuda_compiler_version == "10.2" or (linux and cuda_compiler_version == "11.1")]

@h-vetinari h-vetinari Jul 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything below 11.2 has been droppped from conda-forge, so we can simplify this condition (and remove the comment above)

@h-vetinari

h-vetinari commented Jul 28, 2023

Copy link
Copy Markdown
Member

Resolves #41

Have you tested that this resolves #41? I tend to think that it doesn't even need solving, see my comment there.

@mmcauliffe

mmcauliffe commented Jul 29, 2023

Copy link
Copy Markdown
Contributor Author

I have gotten the simple conda build recipe working from the repo root directory this way on windows.

@mmcauliffe

mmcauliffe commented Jul 29, 2023

Copy link
Copy Markdown
Contributor Author

I do also have #39 working now (was not expecting to get that working today), so it might be worth closing this and incorporating it and your comments into that one (specifically the cuda version ones)?

@h-vetinari

h-vetinari commented Jul 29, 2023

Copy link
Copy Markdown
Member

I have gotten the simple conda build recipe working from the repo root directory this way on windows.

OK, if that works, then I guess that doesn't hurt. I can bring over the changes to #39 if you want.

@mmcauliffe

mmcauliffe commented Jul 29, 2023

Copy link
Copy Markdown
Contributor Author

Changes incorporated in #39

@mmcauliffe mmcauliffe closed this Jul 29, 2023
@mmcauliffe
mmcauliffe deleted the fix-local-windows branch July 29, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari left review comments
@mcernak mcernak Awaiting requested review from mcernak mcernak is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmcauliffe @h-vetinari