[WIP] Cuda12 rebuild again - #182
Conversation
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libblas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏
Add use_mkldnn Add CFLAGS to silence gcc-12 false positive error
Add some CUDA 12 deps Change around some env variables Compile with cmake instead of pip (pip seems to ignore parallel builds)
…nda-forge-pinning 2023.08.17.12.03.01
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
OSX builds run into this error pytorch/pytorch#99035 |
|
Silencing causes this error in CMake: |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Interesting wonder why AVX512 support is a hard requirement? Not all CPUs have those instructions |
|
I think we should just set The check for avx512 is different in pytorch where they decide whether to build fbgemm (https://github.com/pytorch/pytorch/blob/71632d4d24616ddad6685814aae4ae54c981c0d2/cmake/MiscCheck.cmake#L43-L83 - this succeeds) and within fbgemm itself (https://github.com/pytorch/FBGEMM/blob/d43717ad9f62c30a89a31d537303e7d5970c1018/CMakeLists.txt#L111-L122 - fails). |
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
…, and conda-forge-pinning 2023.08.17.12.03.01" This reverts commit 81b9146.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
The lingering issues are:
Traceback (most recent call last):
File "backends/xeon/test_launch.py", line 65, in <module>
run_tests()
File "/Users/runner/miniforge3/conda-bld/pytorch-recipe_1693911031252/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.8/site-packages/torch/testing/_internal/common_utils.py", line 765, in run_tests
from xmlrunner.result import _XMLTestResult # type: ignore[import]
ModuleNotFoundError: No module named 'xmlrunner.result'
FINISHED PRINTING LOG FILE of backends/xeon/test_launch (/Users/runner/miniforge3/conda-bld/pytorch-recipe_1693911031252/test_tmp/test/test-reports/backends-xeon-test_launch_kar0386k.log)
backends/xeon/test_launch failed!
Traceback (most recent call last):
File "./test/run_test.py", line 1394, in <module>
main()
File "./test/run_test.py", line 1352, in main
raise RuntimeError(
RuntimeError: backends/xeon/test_launch failed!
But the xmlrunner package is being installed, and this error is not present in many other osx builds.
with channels:
The reported errors are:
- Encountered problems while solving:
- - package pytorch-2.0.0-cpu_generic_py38h1a61d8b_1 requires mkl >=2022.2.1,<2023.0a0, but none of the providers can be installed
- weird because the mkl package is installed during build just fine. |
|
Now that PR ( #195 ) is in, should we close this? |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)There were some conflicts in my previous PR #181 , I think I was able to solve them.