Skip to content

Up to 2.1.0 - #194

Closed
RaulPPelaez wants to merge 39 commits into
conda-forge:mainfrom
RaulPPelaez:up210
Closed

Up to 2.1.0#194
RaulPPelaez wants to merge 39 commits into
conda-forge:mainfrom
RaulPPelaez:up210

Conversation

@RaulPPelaez

@RaulPPelaez RaulPPelaez commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I tried to follow the build instructions in pytorch for this one: https://github.com/pytorch/pytorch#from-source

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@RaulPPelaez

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@github-actions

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/6639916701.

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [48, 49]

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@RaulPPelaez

Copy link
Copy Markdown
Contributor Author

Some builds fail when testing with:

import: 'torch'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406509295/test_tmp/run_test.py", line 2, in <module>
    import torch
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406509295/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/torch/__init__.py", line 234, in <module>
    _load_global_deps()
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406509295/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/torch/__init__.py", line 193, in _load_global_deps
    raise err
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406509295/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/site-packages/torch/__init__.py", line 174, in _load_global_deps
    ctypes.CDLL(lib_path, mode=ctypes.RTLD_GLOBAL)
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406509295/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.8/ctypes/__init__.py", line 373, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: libmkl_intel_lp64.so.2: cannot open shared object file: No such file or directory

Others also fail when testing with:

import: 'torch'
import: 'torch'
+ OMP_NUM_THREADS=4
+ python ./test/run_test.py
/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698406493308/test_tmp/./test/run_test.py:18: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
Ignoring disabled issues:  ['']
Unable to import boto3. Will not be emitting metrics.... Reason: No module named 'boto3'
Missing pip dependency: pytest-rerunfailures, please run `pip install -r .ci/docker/requirements-ci.txt`
+ true
+ pip check
torch 2.1.0 requires fsspec, which is not installed.
Tests failed for pytorch-2.1.0-cpu_generic_py310hefbe716_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for pytorch-2.1.0-cpu_generic_py310hefbe716_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: pytorch-2.1.0-cpu_generic_py310hefbe716_0.conda
##[error]Bash exited with code '1'.
Finishing: Run docker build

I added fsspec as a run dep, not sure what to do about the mkl library...

@hmaarrfk

Copy link
Copy Markdown
Contributor

you might need a patch

:
2023-10-27T18:50:59.4206092Z /home/conda/feedstock_root/build_artifacts/pytorch-recipe_1698429688496/work/c10/cuda/CUDACachingAllocator.cpp:1144:15: error: 'nvmlProcessInfo_v1_t' was not declared in this scope; did you mean 'nvmlProcessInfo_t'?

@RaulPPelaez

Copy link
Copy Markdown
Contributor Author

Related pytorch/pytorch#100618

@hmaarrfk

Copy link
Copy Markdown
Contributor

As part of my review, I was looking for:

WARNING (pytorch,lib/python3.10/site-packages/torch/lib/libtorch_global_deps.so): Needed DSO lib/libmkl_intel_lp64.so.2 found in ['mkl']
WARNING (pytorch,lib/python3.10/site-packages/torch/lib/libtorch_global_deps.so): .. but ['mkl'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (pytorch,lib/python3.10/site-packages/torch/lib/libtorch_global_deps.so): Needed DSO lib/libmkl_gnu_thread.so.2 found in ['mkl']
WARNING (pytorch,lib/python3.10/site-packages/torch/lib/libtorch_global_deps.so): .. but ['mkl'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (pytorch,lib/python3.10/site-packages/torch/lib/libtorch_global_deps.so): Needed DSO lib/libmkl_core.so.2 found in ['mkl']

Comment thread recipe/meta.yaml Outdated
@hmaarrfk

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

@hmaarrfk

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

@github-actions

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/6677951260.

Comment thread recipe/build_pytorch.sh
done
unset CMAKE_INSTALL_PREFIX
export TH_BINARY_BUILD=1
# export TH_BINARY_BUILD=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that openblas is not being found, but i'm unsure why there are some seemingly unrelated changes in the build script.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to make sure builds were not failing because of some of these options in the build script. I started by removing them and then add them back when required.

Comment thread recipe/meta.yaml
Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml Outdated
@hmaarrfk

Copy link
Copy Markdown
Contributor

sorry for the all the noise. i'm going to try a few things in: #196

RaulPPelaez and others added 2 commits October 29, 2023 07:09
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@hmaarrfk

Copy link
Copy Markdown
Contributor

I'm really kot sure what the difference between the two PRs is. I mostly just untabbed everything so I can test locally

@jakirkham

Copy link
Copy Markdown
Member

Now that PR ( #199 ) is in, should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants